more cleanup about removing useless include

common/gr_basic.cpp

@@ -24,17 +24,13 @@
 /********************************/
 
 
-#include <fctsys.h>
 #include <gr_basic.h>
-#include <common.h>
 #include <trigo.h>
-#include <macros.h>
 #include <base_struct.h>
 #include <base_screen.h>
 #include <bezier_curves.h>
 #include <math_for_graphics.h>
 #include <wx/graphics.h>
-#include <wx/tokenzr.h>
 #include <geometry/geometry_utils.h>
 #include <math/util.h>      // for KiROUND
 

common/gr_text.cpp

@@ -29,16 +29,13 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <gr_basic.h>
-#include <common.h>
 #include <plotter.h>
-#include <eda_text.h>               // EDA_TEXT_HJUSTIFY_T and EDA_TEXT_VJUSTIFY_T
+#include <eda_text.h>           // EDA_TEXT_HJUSTIFY_T and EDA_TEXT_VJUSTIFY_T
 #include <trigo.h>
-#include <macros.h>
 #include <base_screen.h>
 #include <gr_text.h>
-#include <math/util.h>      // for KiROUND
+#include <math/util.h>          // for KiROUND
 
 #include <basic_gal.h>
 

cvpcb/readwrite_dlgs.cpp

@@ -24,12 +24,10 @@
  */
 
 #include <confirm.h>
-#include <fctsys.h>
 #include <fp_lib_table.h>
 #include <html_messagebox.h>
 #include <kiway.h>
 #include <lib_id.h>
-#include <macros.h>
 
 #include <cvpcb_mainframe.h>
 #include <listboxes.h>

pagelayout_editor/design_inspector.cpp

@@ -24,7 +24,7 @@
 
 #include <wx/imaglist.h>
 #include <wx/wupdlock.h>
-#include <fctsys.h>
+
 #include <ws_draw_item.h>
 #include <ws_data_model.h>
 #include <pl_editor_id.h>

pagelayout_editor/files.cpp

@@ -24,11 +24,8 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
-#include <common.h>
 #include <confirm.h>
 #include <gestfich.h>
-#include <macros.h>
 #include <ws_draw_item.h>
 #include <ws_data_model.h>
 #include <pl_editor_frame.h>

pagelayout_editor/pl_editor_frame.cpp

@@ -23,10 +23,8 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <kiface_i.h>
 #include <pgm_base.h>
-//#include <base_units.h>
 #include <msgpanel.h>
 #include <bitmaps.h>
 #include <dialogs/panel_pl_editor_color_settings.h>

pagelayout_editor/pl_editor_layout.cpp

@@ -29,8 +29,6 @@
 #include <algorithm>
 #include <climits>
 
-#include <fctsys.h>
-#include <common.h>
 #include <eda_rect.h>
 #include <pl_editor_layout.h>
 

pagelayout_editor/pl_editor_undo_redo.cpp

@@ -23,7 +23,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <ws_data_model.h>
 #include <pl_editor_frame.h>
 #include <tool/tool_manager.h>

pagelayout_editor/properties_frame.cpp

@@ -23,7 +23,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <ws_draw_item.h>
 #include <ws_data_model.h>
 #include <project.h>

pagelayout_editor/toolbars_pl_editor.cpp

@@ -19,9 +19,6 @@
  * with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include <fctsys.h>
-#include <common.h>
-#include <macros.h>
 #include <bitmaps.h>
 #include <tool/action_toolbar.h>
 #include <tools/pl_actions.h>

pcbnew/board_connected_item.cpp

@@ -23,7 +23,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <class_board.h>
 #include <class_board_item.h>
 #include <connectivity/connectivity_data.h>

pcbnew/board_design_settings.cpp

@@ -21,8 +21,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
-#include <common.h>
 #include <class_dimension.h>
 #include <class_track.h>
 #include <layers_id_colors_and_visibility.h>

pcbnew/board_items_to_polygon_shape_transform.cpp

@@ -22,11 +22,9 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <vector>
 #include <bezier_curves.h>
 #include <base_units.h>     // for IU_PER_MM
-#include <gr_text.h>
 #include <pcbnew.h>
 #include <pcb_edit_frame.h>
 #include <trigo.h>

pcbnew/build_BOM_from_board.cpp

@@ -25,7 +25,6 @@
 /* build_BOM_from_board.cpp */
 
 
-#include <fctsys.h>
 #include <confirm.h>
 #include <kicad_string.h>
 #include <pcb_edit_frame.h>

pcbnew/class_board.cpp

@@ -27,7 +27,6 @@
 
 #include <algorithm>
 #include <iterator>
-#include <fctsys.h>
 #include <pcb_base_frame.h>
 #include <reporter.h>
 #include <ws_proxy_view_item.h>

pcbnew/class_board_item.cpp

@@ -23,7 +23,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <pcbnew.h>
 #include <wx/debug.h>
 

pcbnew/class_dimension.cpp

@@ -24,8 +24,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
-#include <gr_basic.h>
 #include <bitmaps.h>
 #include <pcb_edit_frame.h>
 #include <base_units.h>

pcbnew/class_drawsegment.cpp

@@ -24,8 +24,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
-#include <gr_basic.h>
 #include <bezier_curves.h>
 #include <pcb_screen.h>
 #include <bitmaps.h>

pcbnew/class_edge_mod.cpp

@@ -24,7 +24,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <bitmaps.h>
 #include <math/util.h>      // for KiROUND
 #include <settings/color_settings.h>

pcbnew/class_marker_pcb.cpp

@@ -23,8 +23,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
-#include <gr_basic.h>
 #include <bitmaps.h>
 #include <base_units.h>
 #include <pcb_base_frame.h>
@@ -78,7 +76,7 @@ MARKER_PCB* MARKER_PCB::Deserialize( const wxString& data )
                              (int) strtol( props[2].c_str(), nullptr, 10 ) );
 
     std::shared_ptr<DRC_ITEM> drcItem =  DRC_ITEM::Create( props[0] );
-    
+
     if( !drcItem )
         return nullptr;
 

pcbnew/class_module.cpp

@@ -24,8 +24,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
-#include <gr_basic.h>
 #include <confirm.h>
 #include <refdes_utils.h>
 #include <bitmaps.h>

pcbnew/class_pad.cpp

@@ -28,9 +28,6 @@
  * D_PAD class implementation.
  */
 
-#include <fctsys.h>
-#include <trigo.h>
-#include <macros.h>
 #include <msgpanel.h>
 #include <base_units.h>
 #include <bitmaps.h>

pcbnew/class_pcb_target.cpp

@@ -29,8 +29,6 @@
  * PCB_TARGET class definition - targets for photo plots, formerly called MIRE (from French 'mire optique')
  */
 
-#include <fctsys.h>
-#include <gr_basic.h>
 #include <bitmaps.h>
 #include <pcb_edit_frame.h>
 #include <class_board.h>

pcbnew/class_pcb_text.cpp

@@ -23,7 +23,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <base_struct.h>
 #include <pcb_edit_frame.h>
 #include <base_units.h>

pcbnew/class_text_mod.cpp

@@ -23,7 +23,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <pcb_edit_frame.h>
 #include <base_units.h>
 #include <bitmaps.h>
@@ -457,10 +456,7 @@ wxString TEXTE_MODULE::GetShownText( int aDepth ) const
 
 std::shared_ptr<SHAPE> TEXTE_MODULE::GetEffectiveShape( PCB_LAYER_ID aLayer ) const
 {
-    const MODULE* module = static_cast<MODULE*>( GetParent() );
+    return GetEffectiveTextShape();
-    auto shape = GetEffectiveTextShape();
-
-    return shape;
 }
 
 

pcbnew/class_track.cpp

@@ -24,7 +24,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <pcb_base_frame.h>
 #include <connectivity/connectivity_data.h>
 #include <class_board.h>

pcbnew/class_zone.cpp

@@ -24,7 +24,6 @@
  */
 
 #include <bitmaps.h>
-#include <fctsys.h>
 #include <geometry/geometry_utils.h>
 #include <geometry/shape_null.h>
 #include <advanced_config.h>

pcbnew/cleanup_item.cpp

@@ -22,7 +22,6 @@
  */
 
 
-#include <fctsys.h>
 #include <cleanup_item.h>
 #include <pcb_base_frame.h>
 

pcbnew/cross-probing.cpp

@@ -36,10 +36,8 @@
 #include <class_track.h>
 #include <collectors.h>
 #include <eda_dde.h>
-#include <fctsys.h>
 #include <kiface_i.h>
 #include <kiway_express.h>
-#include <macros.h>
 #include <netlist_reader/pcb_netlist.h>
 #include <netlist_reader/board_netlist_updater.h>
 #include <pcb_edit_frame.h>
@@ -236,8 +234,8 @@ void PCB_EDIT_FRAME::ExecuteRemoteCommand( const char* cmdline )
 
         pcb->HighLightON();
 
-        auto merge_area = 
+        auto merge_area =
-            [netcode, &bbox]( BOARD_CONNECTED_ITEM* aItem ) 
+            [netcode, &bbox]( BOARD_CONNECTED_ITEM* aItem )
             {
             if( aItem->GetNetCode() == netcode )
             {
@@ -316,7 +314,7 @@ void PCB_EDIT_FRAME::ExecuteRemoteCommand( const char* cmdline )
         screenSize.y = std::max( 10.0, screenSize.y );
         double ratio = std::max( -1.0, fabs( bbSize.y / screenSize.y ) );
         // Original KiCad code for how much to scale the zoom
-        double kicadRatio = std::max( fabs( bbSize.x / screenSize.x ), 
+        double kicadRatio = std::max( fabs( bbSize.x / screenSize.x ),
                                       fabs( bbSize.y / screenSize.y ) );
 
         // LUT to scale zoom ratio to provide reasonable schematic context.  Must work

pcbnew/footprint_edit_frame.cpp

@@ -39,7 +39,6 @@
 #include <dialogs/panel_modedit_defaults.h>
 #include <dialogs/panel_display_options.h>
 #include <dialogs/panel_edit_options.h>
-#include <fctsys.h>
 #include <footprint_edit_frame.h>
 #include <footprint_editor_settings.h>
 #include <footprint_info_impl.h>

pcbnew/footprint_info_impl.cpp

@@ -23,8 +23,6 @@
 #include <footprint_info_impl.h>
 
 #include <class_module.h>
-#include <common.h>
-#include <fctsys.h>
 #include <footprint_info.h>
 #include <fp_lib_table.h>
 #include <html_messagebox.h>
@@ -32,7 +30,6 @@
 #include <kiface_ids.h>
 #include <kiway.h>
 #include <lib_id.h>
-#include <macros.h>
 #include <pgm_base.h>
 #include <wildcards_and_files_ext.h>
 #include <widgets/progress_reporter.h>

pcbnew/footprint_libraries_utils.cpp

@@ -22,7 +22,6 @@
  */
 
 #include <wx/ffile.h>
-#include <fctsys.h>
 #include <pgm_base.h>
 #include <kiface_i.h>
 #include <confirm.h>
@@ -30,7 +29,6 @@
 #include <pcb_edit_frame.h>
 #include <dialog_helpers.h>
 #include <filter_reader.h>
-#include <macros.h>
 #include <fp_lib_table.h>
 #include <validators.h>
 #include <dialog_text_entry.h>

pcbnew/footprint_viewer_frame.cpp

@@ -31,7 +31,6 @@
 #include <confirm.h>
 #include <dialog_helpers.h>
 #include <eda_pattern_match.h>
-#include <fctsys.h>
 #include <footprint_info.h>
 #include <footprint_viewer_frame.h>
 #include <fp_lib_table.h>

pcbnew/footprint_wizard_frame.cpp

@@ -24,13 +24,11 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <kiface_i.h>
 #include <pcb_draw_panel_gal.h>
 #include <pcb_edit_frame.h>
 #include <3d_viewer/eda_3d_viewer.h>
 #include <msgpanel.h>
-#include <macros.h>
 #include <bitmaps.h>
 #include <grid_tricks.h>
 #include <class_board.h>

pcbnew/footprint_wizard_frame_functions.cpp

@@ -23,8 +23,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
-#include <gr_basic.h>
 #include <pcb_edit_frame.h>
 #include <dialog_helpers.h>
 

pcbnew/graphics_cleaner.cpp

@@ -23,7 +23,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <reporter.h>
 #include <board_commit.h>
 #include <cleanup_item.h>

pcbnew/pcb_edit_frame.cpp

@@ -20,7 +20,6 @@
  * with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include <fctsys.h>
 #include <kiface_i.h>
 #include <kiway.h>
 #include <pgm_base.h>

pcbnew/pcb_screen.cpp

@@ -24,7 +24,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <pcb_screen.h>
 #include <layers_id_colors_and_visibility.h>
 

pcbnew/pcbnew_config.cpp

@@ -24,7 +24,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <pcb_edit_frame.h>
 #include <panel_hotkeys_editor.h>
 #include <panel_edit_options.h>

pcbnew/toolbars_footprint_editor.cpp

@@ -20,9 +20,7 @@
  * with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include <fctsys.h>
 #include <tool/actions.h>
-#include <pcbnew.h>
 #include <class_board.h>
 #include <footprint_edit_frame.h>
 #include <dialog_helpers.h>

pcbnew/toolbars_pcb_editor.cpp

@@ -24,16 +24,15 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
+#include <memory>
+
 #include <bitmaps.h>
 #include <class_board.h>
 #include <confirm.h>
 #include <dialog_helpers.h>
-#include <fctsys.h>
 #include <kiface_i.h>
-#include <memory>
 #include <pcb_edit_frame.h>
 #include <pcb_layer_box_selector.h>
-#include <pcbnew.h>
 #include <pcbnew_id.h>
 #include <pcbnew_settings.h>
 #include <pgm_base.h>