haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Enable meander radius for diff-pairs. 

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16820
This commit is contained in:
Jeff Young 2024-01-30 12:35:13 +00:00
parent dc21defab7
commit 88cc029ad3
3 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pcbnew/dialogs/panel_setup_tuning_patterns.cpp
View File

@ -69,7 +69,7 @@ bool PANEL_SETUP_TUNING_PATTERNS::TransferDataToWindow()
m_dp_maxA.SetValue( m_dpSettings.m_maxAmplitude );
m_dp_spacing.SetValue( m_dpSettings.m_spacing );
m_dp_cornerCtrl->SetSelection( m_dpSettings.m_cornerStyle == PNS::MEANDER_STYLE_ROUND ? 1 : 0 );
m_dp_r.SetValue( 100 );
m_dp_r.SetValue( m_dpSettings.m_cornerRadiusPercentage );
m_dp_singleSided->SetValue( m_dpSettings.m_singleSided );
m_skew_minA.SetValue( m_skewSettings.m_minAmplitude );
@ -97,8 +97,7 @@ bool PANEL_SETUP_TUNING_PATTERNS::TransferDataFromWindow()
m_dpSettings.m_spacing = m_dp_spacing.GetIntValue();
m_dpSettings.m_cornerStyle = m_dp_cornerCtrl->GetSelection() ? PNS::MEANDER_STYLE_ROUND
: PNS::MEANDER_STYLE_CHAMFER;
// TODO: fix diff-pair meandering so we can use non-100% radii
m_dpSettings.m_cornerRadiusPercentage = 100;
m_dpSettings.m_cornerRadiusPercentage = m_dp_r.GetIntValue();
m_dpSettings.m_singleSided = m_dp_singleSided->GetValue();
m_skewSettings.m_minAmplitude = m_skew_minA.GetIntValue();

6
pcbnew/dialogs/panel_setup_tuning_patterns_base.cpp
View File

@ -247,19 +247,13 @@ PANEL_SETUP_TUNING_PATTERNS_BASE::PANEL_SETUP_TUNING_PATTERNS_BASE( wxWindow* pa
m_dp_rLabel = new wxStaticText( this, wxID_ANY, _("Radius (r):"), wxDefaultPosition, wxDefaultSize, 0 );
m_dp_rLabel->Wrap( -1 );
m_dp_rLabel->Enable( false );
fgSizer32->Add( m_dp_rLabel, 0, wxALIGN_CENTER_VERTICAL|wxLEFT, 15 );
m_dp_rCtrl = new TEXT_CTRL_EVAL( this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxDefaultSize, 0 );
m_dp_rCtrl->Enable( false );
fgSizer32->Add( m_dp_rCtrl, 0, wxEXPAND|wxALIGN_CENTER_VERTICAL, 5 );
m_dp_rUnits = new wxStaticText( this, wxID_ANY, _("%"), wxDefaultPosition, wxDefaultSize, 0 );
m_dp_rUnits->Wrap( -1 );
m_dp_rUnits->Enable( false );
fgSizer32->Add( m_dp_rUnits, 0, wxALIGN_CENTER_VERTICAL, 5 );

6
pcbnew/dialogs/panel_setup_tuning_patterns_base.fbp
View File

@ -2374,7 +2374,7 @@
<property name="dock_fixed">0</property>
<property name="docking">Left</property>
<property name="drag_accept_files">0</property>
<property name="enabled">0</property>
<property name="enabled">1</property>
<property name="fg"></property>
<property name="floatable">1</property>
<property name="font"></property>
@ -2436,7 +2436,7 @@
<property name="dock_fixed">0</property>
<property name="docking">Left</property>
<property name="drag_accept_files">0</property>
<property name="enabled">0</property>
<property name="enabled">1</property>
<property name="fg"></property>
<property name="floatable">1</property>
<property name="font"></property>
@ -2501,7 +2501,7 @@
<property name="dock_fixed">0</property>
<property name="docking">Left</property>
<property name="drag_accept_files">0</property>
<property name="enabled">0</property>
<property name="enabled">1</property>
<property name="fg"></property>
<property name="floatable">1</property>
<property name="font"></property>