haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed signed vs unsigned integer comparisons

This commit is contained in:
Maciej Suminski 2017-11-14 15:05:35 +01:00
parent 658dd362cd
commit 8dabcc0125
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
eeschema/lib_manager.cpp
View File

@ -283,7 +283,7 @@ std::list<LIB_ALIAS*> LIB_MANAGER::GetAliases( const wxString& aLibrary ) const
{ {
for( auto& partBuf : libIt->second.GetBuffers() ) for( auto& partBuf : libIt->second.GetBuffers() )
{ {
for( int i = 0; i < partBuf->GetPart()->GetAliasCount(); ++i ) for( unsigned int i = 0; i < partBuf->GetPart()->GetAliasCount(); ++i )
ret.push_back( partBuf->GetPart()->GetAlias( i ) ); ret.push_back( partBuf->GetPart()->GetAlias( i ) );
} }
} }
@ -719,7 +719,7 @@ bool LIB_MANAGER::LIB_BUFFER::addAliases( PART_BUFFER::PTR aPartBuf )
wxCHECK( part, false ); wxCHECK( part, false );
bool ret = true; // Assume everything is ok bool ret = true; // Assume everything is ok
for( int i = 0; i < part->GetAliasCount(); ++i ) for( unsigned int i = 0; i < part->GetAliasCount(); ++i )
{ {
bool newAlias; bool newAlias;
std::tie( std::ignore, newAlias ) = m_aliases.emplace( part->GetAlias( i )->GetName(), aPartBuf ); std::tie( std::ignore, newAlias ) = m_aliases.emplace( part->GetAlias( i )->GetName(), aPartBuf );
@ -741,7 +741,7 @@ bool LIB_MANAGER::LIB_BUFFER::removeAliases( PART_BUFFER::PTR aPartBuf )
wxCHECK( part, false ); wxCHECK( part, false );
bool ret = true; // Assume everything is ok bool ret = true; // Assume everything is ok
for( int i = 0; i < part->GetAliasCount(); ++i ) for( unsigned int i = 0; i < part->GetAliasCount(); ++i )
{ {
auto aliasIt = m_aliases.find( part->GetAlias( i )->GetName() ); auto aliasIt = m_aliases.find( part->GetAlias( i )->GetName() );

2
eeschema/libedit.cpp
View File

@ -432,7 +432,7 @@ void LIB_EDIT_FRAME::fixDuplicateAliases( LIB_PART* aPart, const wxString& aLibr
{ {
wxString newName; wxString newName;
for( int i = 0; i < aPart->GetAliasCount(); ++i ) for( unsigned int i = 0; i < aPart->GetAliasCount(); ++i )
{ {
LIB_ALIAS* alias = aPart->GetAlias( i ); LIB_ALIAS* alias = aPart->GetAlias( i );
int sfx = 0; int sfx = 0;