haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't try and infer optimum widths for board minimums. 

It doesn't work well with sorting the implicit rules by clearance.

Fixes https://gitlab.com/kicad/code/kicad/issues/5951
This commit is contained in:
Jeff Young 2020-10-11 16:35:31 +01:00
parent 8fcb6c6f05
commit 8e70381be3
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pcbnew/drc/drc_engine.cpp
View File

@ -100,12 +100,10 @@ void DRC_ENGINE::loadImplicitRules()
DRC_CONSTRAINT widthConstraint( DRC_CONSTRAINT_TYPE_TRACK_WIDTH ); DRC_CONSTRAINT widthConstraint( DRC_CONSTRAINT_TYPE_TRACK_WIDTH );
widthConstraint.Value().SetMin( bds.m_TrackMinWidth ); widthConstraint.Value().SetMin( bds.m_TrackMinWidth );
widthConstraint.Value().SetOpt( bds.GetDefault()->GetTrackWidth() );
rule->AddConstraint( widthConstraint ); rule->AddConstraint( widthConstraint );
DRC_CONSTRAINT drillConstraint( DRC_CONSTRAINT_TYPE_HOLE_SIZE ); DRC_CONSTRAINT drillConstraint( DRC_CONSTRAINT_TYPE_HOLE_SIZE );
drillConstraint.Value().SetMin( bds.m_MinThroughDrill ); drillConstraint.Value().SetMin( bds.m_MinThroughDrill );
drillConstraint.Value().SetOpt( bds.GetDefault()->GetViaDrill() );
rule->AddConstraint( drillConstraint ); rule->AddConstraint( drillConstraint );
DRC_CONSTRAINT annulusConstraint( DRC_CONSTRAINT_TYPE_ANNULAR_WIDTH ); DRC_CONSTRAINT annulusConstraint( DRC_CONSTRAINT_TYPE_ANNULAR_WIDTH );
@ -114,7 +112,6 @@ void DRC_ENGINE::loadImplicitRules()
DRC_CONSTRAINT diameterConstraint( DRC_CONSTRAINT_TYPE_VIA_DIAMETER ); DRC_CONSTRAINT diameterConstraint( DRC_CONSTRAINT_TYPE_VIA_DIAMETER );
diameterConstraint.Value().SetMin( bds.m_ViasMinSize ); diameterConstraint.Value().SetMin( bds.m_ViasMinSize );
diameterConstraint.Value().SetOpt( bds.GetDefault()->GetViaDiameter() );
rule->AddConstraint( diameterConstraint ); rule->AddConstraint( diameterConstraint );
DRC_CONSTRAINT edgeClearanceConstraint( DRC_CONSTRAINT_TYPE_EDGE_CLEARANCE ); DRC_CONSTRAINT edgeClearanceConstraint( DRC_CONSTRAINT_TYPE_EDGE_CLEARANCE );
@ -135,7 +132,6 @@ void DRC_ENGINE::loadImplicitRules()
DRC_CONSTRAINT diffPairGapConstraint( DRC_CONSTRAINT_TYPE_DIFF_PAIR_GAP ); DRC_CONSTRAINT diffPairGapConstraint( DRC_CONSTRAINT_TYPE_DIFF_PAIR_GAP );
diffPairGapConstraint.Value().SetMin( bds.GetDefault()->GetClearance() ); diffPairGapConstraint.Value().SetMin( bds.GetDefault()->GetClearance() );
diffPairGapConstraint.Value().SetOpt( bds.GetDefault()->GetClearance() );
rule->AddConstraint( diffPairGapConstraint ); rule->AddConstraint( diffPairGapConstraint );
@ -147,12 +143,10 @@ void DRC_ENGINE::loadImplicitRules()
DRC_CONSTRAINT uViaDrillConstraint( DRC_CONSTRAINT_TYPE_HOLE_SIZE ); DRC_CONSTRAINT uViaDrillConstraint( DRC_CONSTRAINT_TYPE_HOLE_SIZE );
uViaDrillConstraint.Value().SetMin( bds.m_MicroViasMinDrill ); uViaDrillConstraint.Value().SetMin( bds.m_MicroViasMinDrill );
uViaDrillConstraint.Value().SetOpt( bds.GetDefault()->GetuViaDrill() );
uViaRule->AddConstraint( uViaDrillConstraint ); uViaRule->AddConstraint( uViaDrillConstraint );
DRC_CONSTRAINT uViaDiameterConstraint( DRC_CONSTRAINT_TYPE_VIA_DIAMETER ); DRC_CONSTRAINT uViaDiameterConstraint( DRC_CONSTRAINT_TYPE_VIA_DIAMETER );
uViaDiameterConstraint.Value().SetMin( bds.m_MicroViasMinSize ); uViaDiameterConstraint.Value().SetMin( bds.m_MicroViasMinSize );
uViaDiameterConstraint.Value().SetOpt( bds.GetDefault()->GetuViaDiameter() );
uViaRule->AddConstraint( uViaDiameterConstraint ); uViaRule->AddConstraint( uViaDiameterConstraint );
if( !bds.m_MicroViasAllowed ) if( !bds.m_MicroViasAllowed )