Silence some msvc warnings

- exception variables that were unused
- RAYSEG2D improperly foward declared with class instead of struct
- unused vars

3d-viewer/3d_canvas/board_adapter.cpp

@@ -154,8 +154,6 @@ bool BOARD_ADAPTER::Is3dLayerEnabled( PCB_LAYER_ID aLayer ) const
     if( !m_board->IsLayerEnabled( aLayer ) )
         return false;
 
-    DISPLAY3D_FLG flg;
-
     // see if layer needs to be shown
     // check the flags
     switch( aLayer )

3d-viewer/3d_canvas/eda_3d_canvas.cpp

@@ -499,7 +499,7 @@ void EDA_3D_CANVAS::DoRePaint()
             if( reloadRaytracingForIntersectionCalculations )
                 m_3d_render_raytracing->Reload( nullptr, nullptr, true );
         }
-        catch( std::runtime_error& err )
+        catch( std::runtime_error& )
         {
             m_is_opengl_version_supported = false;
             m_opengl_supports_raytracing  = false;

3d-viewer/3d_rendering/3d_render_raytracing/shapes2D/layer_item_2d.h

@@ -33,7 +33,7 @@
 #include "object_2d.h"
 #include <vector>
 
-class RAYSEG2D;
+struct RAYSEG2D;
 
 #define CSGITEM_EMPTY 0
 #define CSGITEM_FULL (OBJECT_2D*) ( ( size_t )( -1 ) )

common/gal/opengl/opengl_gal.cpp

@@ -439,7 +439,7 @@ void OPENGL_GAL::beginDrawing()
         {
             overlayBuffer = compositor->CreateBuffer();
         }
-        catch( const std::runtime_error& error )
+        catch( const std::runtime_error& )
         {
             wxLogVerbose( "Could not create a framebuffer for overlays.\n" );
             overlayBuffer = 0;

common/kiid.cpp

@@ -69,7 +69,7 @@ KIID::KIID()
 
 #if BOOST_VERSION >= 106700
     }
-    catch( const boost::uuids::entropy_error& e )
+    catch( const boost::uuids::entropy_error& )
     {
         wxLogFatalError( "A Boost UUID entropy exception was thrown in %s:%s.",
                          __FILE__, __FUNCTION__ );
@@ -121,7 +121,7 @@ KIID::KIID( const wxString& aString ) : m_uuid(), m_cached_timestamp( 0 )
 
 #if BOOST_VERSION >= 106700
             }
-            catch( const boost::uuids::entropy_error& e )
+            catch( const boost::uuids::entropy_error& )
             {
                 wxLogFatalError( "A Boost UUID entropy exception was thrown in %s:%s.",
                                  __FILE__, __FUNCTION__ );

eeschema/symbol_lib_table.cpp

@@ -406,7 +406,7 @@ SYMBOL_LIB_TABLE::SAVE_T SYMBOL_LIB_TABLE::SaveSymbol( const wxString& aNickname
     {
         row->plugin->SaveSymbol( row->GetFullURI( true ), aSymbol, row->GetProperties() );
     }
-    catch( const IO_ERROR& ioe )
+    catch( const IO_ERROR& )
     {
         return SAVE_SKIPPED;
     }

eeschema/tools/sch_editor_control.cpp

@@ -1378,7 +1378,7 @@ int SCH_EDITOR_CONTROL::Paste( const TOOL_EVENT& aEvent )
     {
         plugin.LoadContent( reader, &paste_sheet );
     }
-    catch( IO_ERROR& ioe )
+    catch( IO_ERROR& )
     {
         // If it wasn't content, then paste as text
         paste_screen->Append( new SCH_TEXT( wxPoint( 0, 0 ), text ) );

pcbnew/drc/drc_engine.cpp

@@ -634,7 +634,7 @@ void DRC_ENGINE::InitEngine( const wxFileName& aRulePath )
             loadImplicitRules();
             compileRules();
         }
-        catch( PARSE_ERROR& ignore )
+        catch( PARSE_ERROR& )
         {
             wxFAIL_MSG( "Compiling implict rules failed." );
         }

thirdparty/other_math/math_for_graphics.cpp

@@ -224,7 +224,7 @@ bool TestForIntersectionOfStraightLineSegments( int x1i, int y1i, int x1f, int y
         b   = double( y1f - y1i ) / (x1f - x1i);
         a   = (double) y1i - b * x1i;
 
-        double  x1, y1, x2, y2;
+        double  x1, y1;
         bool    test = FindLineSegmentIntersection( a, b, x2i, y2i, x2f, y2f, x1, y1 );
 
         if( test )