haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PNS: Modify MarkObstacles logic to select shorter 

When routing where we hit multiple obstacles, we choose the shortest
path to allow overlapping hits to choose the shorter path, thus giving a
better chance of returning true for the DRC-compliant path.

Fixes #3773 | https://gitlab.com/kicad/code/kicad/issues/3773

(cherry picked from commit 38f13ef481)
This commit is contained in:
Seth Hillbrand 2020-01-16 19:54:51 -08:00
parent 9f17d91b32
commit 923dad6ca8
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pcbnew/router/pns_line_placer.cpp
View File

@ -2,7 +2,7 @@
* KiRouter - a push-and-(sometimes-)shove PCB router * KiRouter - a push-and-(sometimes-)shove PCB router
* *
* Copyright (C) 2013-2017 CERN * Copyright (C) 2013-2017 CERN
* Copyright (C) 2016 KiCad Developers, see AUTHORS.txt for contributors. * Copyright (C) 2016-2020 KiCad Developers, see AUTHORS.txt for contributors.
* Author: Tomasz Wlostowski <tomasz.wlostowski@cern.ch> * Author: Tomasz Wlostowski <tomasz.wlostowski@cern.ch>
* *
* This program is free software: you can redistribute it and/or modify it * This program is free software: you can redistribute it and/or modify it
@ -450,7 +450,10 @@ bool LINE_PLACER::rhMarkObstacles( const VECTOR2I& aP, LINE& aNewHead )
if( ( nearest - aP ).EuclideanNorm() < newHead.Width() + cl ) if( ( nearest - aP ).EuclideanNorm() < newHead.Width() + cl )
{ {
buildInitialLine( nearest, newHead ); buildInitialLine( nearest, newHead );
if ( newHead.CLine().Length() > bestHead.CLine().Length() )
// We want the shortest line here to ensure we don't break a clearance
// rule on larger, overlapping items (e.g. vias)
if( newHead.CLine().Length() < bestHead.CLine().Length() )
{ {
bestHead = newHead; bestHead = newHead;
hasBest = true; hasBest = true;