haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PCB_EXPR_EVALUATOR: don't use string comparison to check for undefined enum values

This commit is contained in:
Tomasz Wlostowski 2021-05-03 14:04:15 +02:00
parent ce0ec29fe6
commit 939b5e1932
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pcbnew/pcb_expr_evaluator.cpp
View File

@ -870,17 +870,18 @@ LIBEVAL::VALUE PCB_EXPR_VAR_REF::GetValue( LIBEVAL::CONTEXT* aCtx )
if( !m_isEnum )
{
str = item->Get<wxString>( it->second );
return LIBEVAL::VALUE( str );
}
else
{
const wxAny& any = item->Get( it->second );
any.GetAs<wxString>( &str );
bool valid = any.GetAs<wxString>( &str );
if( valid )
return LIBEVAL::VALUE( str );
}
if( str == "UNDEFINED" )
return LIBEVAL::VALUE();
else
return LIBEVAL::VALUE( str );
return LIBEVAL::VALUE();
}
}
}