haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Generate changed message before making change. 

Otherwise we've lost the "before" value.

Fixes https://gitlab.com/kicad/code/kicad/issues/8186
This commit is contained in:
Jeff Young 2021-04-13 13:43:02 +01:00
parent 55d2d0d93e
commit 94e8855c13
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
pcbnew/netlist_reader/board_netlist_updater.cpp
View File

@ -268,12 +268,12 @@ bool BOARD_NETLIST_UPDATER::updateFootprintParameters( FOOTPRINT* aPcbFootprint,
} }
else else
{ {
changed = true;
aPcbFootprint->SetReference( aNetlistComponent->GetReference() );
msg.Printf( _( "Changed %s reference designator to %s." ), msg.Printf( _( "Changed %s reference designator to %s." ),
aPcbFootprint->GetReference(), aPcbFootprint->GetReference(),
aNetlistComponent->GetReference() ); aNetlistComponent->GetReference() );
changed = true;
aPcbFootprint->SetReference( aNetlistComponent->GetReference() );
} }
m_reporter->Report( msg, RPT_SEVERITY_ACTION ); m_reporter->Report( msg, RPT_SEVERITY_ACTION );
@ -291,13 +291,13 @@ bool BOARD_NETLIST_UPDATER::updateFootprintParameters( FOOTPRINT* aPcbFootprint,
} }
else else
{ {
changed = true;
aPcbFootprint->SetValue( aNetlistComponent->GetValue() );
msg.Printf( _( "Changed %s value from %s to %s." ), msg.Printf( _( "Changed %s value from %s to %s." ),
aPcbFootprint->GetReference(), aPcbFootprint->GetReference(),
aPcbFootprint->GetValue(), aPcbFootprint->GetValue(),
aNetlistComponent->GetValue() ); aNetlistComponent->GetValue() );
changed = true;
aPcbFootprint->SetValue( aNetlistComponent->GetValue() );
} }
m_reporter->Report( msg, RPT_SEVERITY_ACTION ); m_reporter->Report( msg, RPT_SEVERITY_ACTION );
@ -318,13 +318,13 @@ bool BOARD_NETLIST_UPDATER::updateFootprintParameters( FOOTPRINT* aPcbFootprint,
} }
else else
{ {
changed = true;
aPcbFootprint->SetPath( new_path );
msg.Printf( _( "Updated %s symbol association from %s to %s." ), msg.Printf( _( "Updated %s symbol association from %s to %s." ),
aPcbFootprint->GetReference(), aPcbFootprint->GetReference(),
aPcbFootprint->GetPath().AsString(), aPcbFootprint->GetPath().AsString(),
new_path.AsString() ); new_path.AsString() );
changed = true;
aPcbFootprint->SetPath( new_path );
} }
m_reporter->Report( msg, RPT_SEVERITY_ACTION ); m_reporter->Report( msg, RPT_SEVERITY_ACTION );
@ -339,11 +339,11 @@ bool BOARD_NETLIST_UPDATER::updateFootprintParameters( FOOTPRINT* aPcbFootprint,
} }
else else
{ {
changed = true;
aPcbFootprint->SetProperties( aNetlistComponent->GetProperties() );
msg.Printf( _( "Updated %s properties." ), msg.Printf( _( "Updated %s properties." ),
aPcbFootprint->GetReference() ); aPcbFootprint->GetReference() );
changed = true;
aPcbFootprint->SetProperties( aNetlistComponent->GetProperties() );
} }
m_reporter->Report( msg, RPT_SEVERITY_ACTION ); m_reporter->Report( msg, RPT_SEVERITY_ACTION );