haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update all units when a schematic symbol is edited in the Symbol Editor. 

Fixes https://gitlab.com/kicad/code/kicad/issues/13208
This commit is contained in:
Jeff Young 2022-12-19 21:05:56 +00:00
parent 389f0655cd
commit 97010b598d
1 changed files with 41 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
eeschema/sch_edit_frame.cpp
View File

@ -1759,35 +1759,51 @@ void SCH_EDIT_FRAME::SaveSymbolToSchematic( const LIB_SYMBOL& aSymbol,
{ {
bool appendToUndo = false; bool appendToUndo = false;
SCH_SHEET_PATH sheetPath; SCH_SHEET_PATH principalPath;
SCH_ITEM* item = Schematic().GetSheets().GetItem( aSchematicSymbolUUID, &sheetPath ); SCH_ITEM* item = Schematic().GetSheets().GetItem( aSchematicSymbolUUID, &principalPath );
SCH_SYMBOL* principalSymbol = dynamic_cast<SCH_SYMBOL*>( item );
if( item ) if( !principalSymbol )
return;
wxString principalRef;
if( principalSymbol->IsAnnotated( &principalPath ) )
principalRef = principalSymbol->GetRef( &principalPath, false );
for( const SCH_SHEET_PATH& path : Schematic().GetSheets() )
{ {
SCH_SYMBOL* symbol = dynamic_cast<SCH_SYMBOL*>( item ); for( SCH_ITEM* candidate : path.LastScreen()->Items().OfType( SCH_SYMBOL_T ) )
wxCHECK( symbol, /* void */ );
// This needs to be done before the LIB_SYMBOL is changed to prevent stale library
// symbols in the schematic file.
sheetPath.LastScreen()->Remove( symbol );
if( !symbol->IsNew() )
{ {
SaveCopyInUndoList( sheetPath.LastScreen(), symbol, UNDO_REDO::CHANGED, appendToUndo ); SCH_SYMBOL* candidateSymbol = static_cast<SCH_SYMBOL*>( candidate );
appendToUndo = true;
if( candidateSymbol == principalSymbol
|| ( candidateSymbol->IsAnnotated( &path )
&& candidateSymbol->GetRef( &path, false ) == principalRef ) )
{
// This needs to be done before the LIB_SYMBOL is changed to prevent stale
// library symbols in the schematic file.
path.LastScreen()->Remove( candidateSymbol );
if( !candidateSymbol->IsNew() )
{
SaveCopyInUndoList( path.LastScreen(), candidateSymbol,
UNDO_REDO::CHANGED, appendToUndo );
appendToUndo = true;
}
candidateSymbol->SetLibSymbol( aSymbol.Flatten().release() );
candidateSymbol->UpdateFields( &GetCurrentSheet(),
true, /* update style */
true, /* update ref */
true, /* update other fields */
false, /* reset ref */
false /* reset other fields */ );
path.LastScreen()->Append( candidateSymbol );
GetCanvas()->GetView()->Update( candidateSymbol );
}
} }
symbol->SetLibSymbol( aSymbol.Flatten().release() );
symbol->UpdateFields( &GetCurrentSheet(),
true, /* update style */
true, /* update ref */
true, /* update other fields */
false, /* reset ref */
false /* reset other fields */ );
sheetPath.LastScreen()->Append( symbol );
GetCanvas()->GetView()->Update( symbol );
} }
GetCanvas()->Refresh(); GetCanvas()->Refresh();