haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DIALOG_SHIM: do not raise invisible windows on wxMSW 

Raise() invokes SetFocus() on Windows OS, leading to an API error
(check wxWindowMSW::SetFocus() in wxWidgets/src/msw/window.cpp as
of wxWidgets 3.0.2). In certain cases it leads to a crash.
This commit is contained in:
Maciej Suminski 2017-11-19 02:39:52 +01:00
parent e0e4e5f1be
commit 98c99ff129
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common/dialog_shim.cpp
View File

@ -155,7 +155,9 @@ bool DIALOG_SHIM::Show( bool show )
// If showing, use previous position and size. // If showing, use previous position and size.
if( show ) if( show )
{ {
#ifndef __WINDOWS__
wxDialog::Raise(); // Needed on OS X and some other window managers (i.e. Unity) wxDialog::Raise(); // Needed on OS X and some other window managers (i.e. Unity)
#endif
ret = wxDialog::Show( show ); ret = wxDialog::Show( show );
// classname is key, returns a zeroed out default EDA_RECT if none existed before. // classname is key, returns a zeroed out default EDA_RECT if none existed before.