haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cvpcb: fix possible crash when pressing the ESC key during some calculations. 

It was due to calls to wxSafeYield() than can fire a Close Event during calculations
modifying widgets inside the main frame.
Fixes #8920
https://gitlab.com/kicad/code/kicad/issues/8920
This commit is contained in:
jean-pierre charras 2021-08-06 11:15:32 +02:00
parent 3747cb50c9
commit 99b242069d
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cvpcb/footprints_listbox.cpp
View File

@ -176,7 +176,6 @@ void FOOTPRINTS_LISTBOX::SetFootprints( FOOTPRINT_LIST& aList, const wxString& a
selection = 0;
DeselectAll();
wxSafeYield();
wxWindowUpdateLocker freeze( this );
DeleteAllItems();

5
cvpcb/readwrite_dlgs.cpp
View File

@ -85,13 +85,14 @@ bool CVPCB_MAINFRAME::ReadNetListAndFpFiles( const std::string& aNetlist )
wxString msg;
bool hasMissingNicks = false;
// Remark: *DO NOT* call wxSafeYield() or wxYield() during these calculations,
// because a Close event (generated by the ESC key) can close some widgets during
// refreshing them here, fired by the wxSafeYield() call.
ReadSchematicNetlist( aNetlist );
if( m_symbolsListBox == nullptr )
return false;
wxSafeYield();
LoadFootprintFiles();
BuildFootprintsListBox();