haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Don't run onPageChanged() event handler during initialization." 

This reverts commit f35ed59868.
This commit is contained in:
Seth Hillbrand 2023-05-24 08:54:16 -07:00
parent 5226855158
commit 9b310ab955
1 changed files with 14 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
pcbnew/dialogs/dialog_board_setup.cpp
View File

@ -54,21 +54,10 @@ DIALOG_BOARD_SETUP::DIALOG_BOARD_SETUP( PCB_EDIT_FRAME* aFrame ) :
_( "Import Settings from Another Board..." ) ), _( "Import Settings from Another Board..." ) ),
m_frame( aFrame ), m_frame( aFrame ),
m_layers( nullptr ), m_layers( nullptr ),
m_physicalStackup( nullptr ), m_physicalStackup( nullptr )
m_currentPage( 0 ),
m_layersPage( 0 ),
m_physicalStackupPage( 0 ),
m_boardFinishPage( 0 ),
m_textAndGraphicsPage( 0 ),
m_formattingPage( 0 ),
m_maskAndPagePage( 0 ),
m_constraintsPage( 0 ),
m_tracksAndViasPage( 0 ),
m_netclassesPage( 0 ),
m_severitiesPage( 0 )
{ {
SetEvtHandlerEnabled( false ); SetEvtHandlerEnabled( false );
m_currentPage = -1;
/* /*
* WARNING: If you change page names you MUST update calls to ShowBoardSetupDialog(). * WARNING: If you change page names you MUST update calls to ShowBoardSetupDialog().
@ -209,8 +198,6 @@ void DIALOG_BOARD_SETUP::onPageChanged( wxBookCtrlEvent& aEvent )
size_t page = aEvent.GetSelection(); size_t page = aEvent.GetSelection();
if( m_physicalStackupPage > 0 ) // Don't run this during initialization
{
if( m_currentPage == m_physicalStackupPage || page == m_physicalStackupPage ) if( m_currentPage == m_physicalStackupPage || page == m_physicalStackupPage )
{ {
m_layers = RESOLVE_PAGE( PANEL_SETUP_LAYERS, m_layersPage ); m_layers = RESOLVE_PAGE( PANEL_SETUP_LAYERS, m_layersPage );
@ -225,7 +212,6 @@ void DIALOG_BOARD_SETUP::onPageChanged( wxBookCtrlEvent& aEvent )
m_physicalStackup->OnLayersOptionsChanged( m_layers->GetUILayerMask() ); m_physicalStackup->OnLayersOptionsChanged( m_layers->GetUILayerMask() );
else if( Prj().IsReadOnly() ) else if( Prj().IsReadOnly() )
KIUI::Disable( m_treebook->GetPage( page ) ); KIUI::Disable( m_treebook->GetPage( page ) );
}
m_currentPage = page; m_currentPage = page;
} }