haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DRC: Verify overlapping layers in physical clearance 

When checking the physical clearance on a layer, it is critical to check
that the via hole exists on that layer.  Blind/buried and micro vias may
not overlap, so should be excluded from this check when they don't exist
on a particular layer

Similarly, we should only be reporting a single physical clearance error
for each item pair even though they may have multiple errors across
multiple layers in the case of via-via clearance
This commit is contained in:
Seth Hillbrand 2023-02-15 11:32:51 -08:00
parent a761b0e860
commit 9d3f4bef6a
1 changed files with 27 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
pcbnew/drc/drc_test_provider_physical_clearance.cpp
View File

@ -71,7 +71,7 @@ public:
} }
private: private:
bool testItemAgainstItem( BOARD_ITEM* aItem, SHAPE* aItemShape, PCB_LAYER_ID aLayer, int testItemAgainstItem( BOARD_ITEM* aItem, SHAPE* aItemShape, PCB_LAYER_ID aLayer,
BOARD_ITEM* other ); BOARD_ITEM* other );
void testItemAgainstZones( BOARD_ITEM* aItem, PCB_LAYER_ID aLayer ); void testItemAgainstZones( BOARD_ITEM* aItem, PCB_LAYER_ID aLayer );
@ -218,8 +218,22 @@ bool DRC_TEST_PROVIDER_PHYSICAL_CLEARANCE::Run()
// Visitor: // Visitor:
[&]( BOARD_ITEM* other ) -> bool [&]( BOARD_ITEM* other ) -> bool
{ {
return testItemAgainstItem( item, itemShape.get(), layer, if( testItemAgainstItem( item, itemShape.get(), layer,
other ); other ) > 0 )
{
BOARD_ITEM* a = item;
BOARD_ITEM* b = other;
// store canonical order
if( static_cast<void*>( a ) > static_cast<void*>( b ) )
std::swap( a, b );
// Once we record one DRC for error for physical clearance
// we don't need to record more
checkedPairs[ { a, b } ].set();
}
return !m_drcEngine->IsCancelled();
}, },
m_board->m_DRCMaxPhysicalClearance ); m_board->m_DRCMaxPhysicalClearance );
@ -575,7 +589,7 @@ void DRC_TEST_PROVIDER_PHYSICAL_CLEARANCE::testZoneLayer( ZONE* aZone, PCB_LAYER
} }
bool DRC_TEST_PROVIDER_PHYSICAL_CLEARANCE::testItemAgainstItem( BOARD_ITEM* aItem, int DRC_TEST_PROVIDER_PHYSICAL_CLEARANCE::testItemAgainstItem( BOARD_ITEM* aItem,
SHAPE* aItemShape, SHAPE* aItemShape,
PCB_LAYER_ID aLayer, PCB_LAYER_ID aLayer,
BOARD_ITEM* other ) BOARD_ITEM* other )
@ -585,6 +599,7 @@ bool DRC_TEST_PROVIDER_PHYSICAL_CLEARANCE::testItemAgainstItem( BOARD_ITEM* aIte
DRC_CONSTRAINT constraint; DRC_CONSTRAINT constraint;
int clearance = 0; int clearance = 0;
int actual; int actual;
int violations = 0;
VECTOR2I pos; VECTOR2I pos;
std::shared_ptr<SHAPE> otherShape = other->GetEffectiveShape( aLayer ); std::shared_ptr<SHAPE> otherShape = other->GetEffectiveShape( aLayer );
@ -610,6 +625,7 @@ bool DRC_TEST_PROVIDER_PHYSICAL_CLEARANCE::testItemAgainstItem( BOARD_ITEM* aIte
drce->SetViolatingRule( constraint.GetParentRule() ); drce->SetViolatingRule( constraint.GetParentRule() );
reportViolation( drce, pos, aLayer ); reportViolation( drce, pos, aLayer );
++violations;
} }
} }
@ -623,6 +639,8 @@ bool DRC_TEST_PROVIDER_PHYSICAL_CLEARANCE::testItemAgainstItem( BOARD_ITEM* aIte
{ {
if( aItem->GetLayerSet().Contains( aLayer ) ) if( aItem->GetLayerSet().Contains( aLayer ) )
itemHoleShape = aItem->GetEffectiveHoleShape(); itemHoleShape = aItem->GetEffectiveHoleShape();
else
return violations;
} }
else if( aItem->HasHole() ) else if( aItem->HasHole() )
{ {
@ -633,6 +651,8 @@ bool DRC_TEST_PROVIDER_PHYSICAL_CLEARANCE::testItemAgainstItem( BOARD_ITEM* aIte
{ {
if( other->GetLayerSet().Contains( aLayer ) ) if( other->GetLayerSet().Contains( aLayer ) )
otherHoleShape = other->GetEffectiveHoleShape(); otherHoleShape = other->GetEffectiveHoleShape();
else
return violations;
} }
else if( other->HasHole() ) else if( other->HasHole() )
{ {
@ -661,6 +681,7 @@ bool DRC_TEST_PROVIDER_PHYSICAL_CLEARANCE::testItemAgainstItem( BOARD_ITEM* aIte
drce->SetViolatingRule( constraint.GetParentRule() ); drce->SetViolatingRule( constraint.GetParentRule() );
reportViolation( drce, pos, aLayer ); reportViolation( drce, pos, aLayer );
++violations;
} }
if( otherHoleShape && otherHoleShape->Collide( aItemShape, clearance, &actual, &pos ) ) if( otherHoleShape && otherHoleShape->Collide( aItemShape, clearance, &actual, &pos ) )
@ -676,11 +697,12 @@ bool DRC_TEST_PROVIDER_PHYSICAL_CLEARANCE::testItemAgainstItem( BOARD_ITEM* aIte
drce->SetViolatingRule( constraint.GetParentRule() ); drce->SetViolatingRule( constraint.GetParentRule() );
reportViolation( drce, pos, aLayer ); reportViolation( drce, pos, aLayer );
++violations;
} }
} }
} }
return !m_drcEngine->IsCancelled(); return violations;
} }