haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Library Manager: fixed a memleak in LIB_EDIT_FRAME::OnCreateNewPart()

This commit is contained in:
Maciej Suminski 2017-11-13 12:34:37 +01:00
parent a2b6c8e20a
commit 9fcaa83b7d
1 changed files with 16 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
eeschema/libedit.cpp
View File

@ -353,39 +353,38 @@ void LIB_EDIT_FRAME::OnCreateNewPart( wxCommandEvent& event )
return; return;
} }
LIB_PART* new_part = new LIB_PART( name ); LIB_PART new_part( name ); // do not create part on the heap, it will be buffered soon
m_aliasName = new_part->GetName(); m_aliasName = name;
new_part.GetReferenceField().SetText( dlg.GetReference() );
new_part.SetUnitCount( dlg.GetUnitCount() );
new_part->GetReferenceField().SetText( dlg.GetReference() ); // Initialize new_part.m_TextInside member:
new_part->SetUnitCount( dlg.GetUnitCount() );
// Initialize new_part->m_TextInside member:
// if 0, pin text is outside the body (on the pin) // if 0, pin text is outside the body (on the pin)
// if > 0, pin text is inside the body // if > 0, pin text is inside the body
new_part->SetConversion( dlg.GetAlternateBodyStyle() ); new_part.SetConversion( dlg.GetAlternateBodyStyle() );
SetShowDeMorgan( dlg.GetAlternateBodyStyle() ); SetShowDeMorgan( dlg.GetAlternateBodyStyle() );
if( dlg.GetPinNameInside() ) if( dlg.GetPinNameInside() )
{ {
new_part->SetPinNameOffset( dlg.GetPinTextPosition() ); new_part.SetPinNameOffset( dlg.GetPinTextPosition() );
if( new_part->GetPinNameOffset() == 0 ) if( new_part.GetPinNameOffset() == 0 )
new_part->SetPinNameOffset( 1 ); new_part.SetPinNameOffset( 1 );
} }
else else
{ {
new_part->SetPinNameOffset( 0 ); new_part.SetPinNameOffset( 0 );
} }
( dlg.GetPowerSymbol() ) ? new_part->SetPower() : new_part->SetNormal(); ( dlg.GetPowerSymbol() ) ? new_part.SetPower() : new_part.SetNormal();
new_part->SetShowPinNumbers( dlg.GetShowPinNumber() ); new_part.SetShowPinNumbers( dlg.GetShowPinNumber() );
new_part->SetShowPinNames( dlg.GetShowPinName() ); new_part.SetShowPinNames( dlg.GetShowPinName() );
new_part->LockUnits( dlg.GetLockItems() ); new_part.LockUnits( dlg.GetLockItems() );
if( dlg.GetUnitCount() < 2 ) if( dlg.GetUnitCount() < 2 )
new_part->LockUnits( false ); new_part.LockUnits( false );
m_libMgr->UpdatePart( new_part, lib ); m_libMgr->UpdatePart( &new_part, lib );
loadPart( name, lib, 1 ); loadPart( name, lib, 1 );
} }