haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Migrate Altium pcblib test to BOOST_DATA_TEST_CASE and use FootprintNeedsUpdate for equality checking

This commit is contained in:
Thomas Pointhuber 2024-05-12 18:41:31 +02:00
parent 21b6b5efbb
commit a44c106f62
2 changed files with 39 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qa/pcbnew_utils/board_test_utils.cpp
View File

@ -319,6 +319,10 @@ void CheckFootprint( const FOOTPRINT* expected, const FOOTPRINT* fp )
} }
// TODO: Groups // TODO: Groups
// Use FootprintNeedsUpdate as sanity check (which should do the same thing as our manually coded checks)
// If we get the reporter working, and COMPARE_FLAGS::DRC is enough for us, we can remove the old code
BOOST_CHECK( !const_cast<FOOTPRINT*>(expected)->FootprintNeedsUpdate(fp, BOARD_ITEM::COMPARE_FLAGS::DRC, nullptr) );
} }

72
qa/tests/pcbnew/pcb_io/altium/test_altium_pcblib_import.cpp
View File

@ -29,10 +29,12 @@
#include <pcbnew_utils/board_test_utils.h> #include <pcbnew_utils/board_test_utils.h>
#include <pcbnew_utils/board_file_utils.h> #include <pcbnew_utils/board_file_utils.h>
#include <qa_utils/wx_utils/unit_test_utils.h> #include <qa_utils/wx_utils/unit_test_utils.h>
#include <boost/test/data/test_case.hpp>
#include <pcbnew/pcb_io/altium/pcb_io_altium_designer.h> #include <pcbnew/pcb_io/altium/pcb_io_altium_designer.h>
#include <pcbnew/pcb_io/kicad_sexpr/pcb_io_kicad_sexpr.h> #include <pcbnew/pcb_io/kicad_sexpr/pcb_io_kicad_sexpr.h>
#include <board.h>
#include <footprint.h> #include <footprint.h>
#include <pad.h> #include <pad.h>
#include <zone.h> #include <zone.h>
@ -52,58 +54,54 @@ struct ALTIUM_PCBLIB_IMPORT_FIXTURE
*/ */
BOOST_FIXTURE_TEST_SUITE( AltiumPcbLibImport, ALTIUM_PCBLIB_IMPORT_FIXTURE ) BOOST_FIXTURE_TEST_SUITE( AltiumPcbLibImport, ALTIUM_PCBLIB_IMPORT_FIXTURE )
static const std::vector<std::tuple<wxString, wxString>> altium_to_kicad_footprint_property = {
{ "Tracks.v5.PcbLib", "Tracks.pretty" },
{ "Tracks.v6.PcbLib", "Tracks.pretty" },
{ "Espressif ESP32-WROOM-32.PcbLib", "Espressif ESP32-WROOM-32.pretty" }
};
/** /**
* Compare all footprints declared in a *.PcbLib file with their KiCad reference footprint * Compare all footprints declared in a *.PcbLib file with their KiCad reference footprint
*/ */
BOOST_AUTO_TEST_CASE( AltiumPcbLibImport ) BOOST_DATA_TEST_CASE( AltiumPcbLibImport2,
boost::unit_test::data::make(altium_to_kicad_footprint_property),
altiumLibraryName,
kicadLibraryName )
{ {
// clang-format off
std::vector<std::pair<wxString, wxString>> tests = {
{ "Tracks.v5.PcbLib", "Tracks.pretty" },
{ "Tracks.v6.PcbLib", "Tracks.pretty" },
{ "Espressif ESP32-WROOM-32.PcbLib", "Espressif ESP32-WROOM-32.pretty" }
};
// clang-format on
std::string dataPath = KI_TEST::GetPcbnewTestDataDir() + "plugins/altium/pcblib/"; std::string dataPath = KI_TEST::GetPcbnewTestDataDir() + "plugins/altium/pcblib/";
for( const std::pair<wxString, wxString>& libName : tests ) wxString altiumLibraryPath = dataPath + altiumLibraryName;
wxString kicadLibraryPath = dataPath + kicadLibraryName;
wxArrayString altiumFootprintNames;
wxArrayString kicadFootprintNames;
altiumPlugin.FootprintEnumerate( altiumFootprintNames, altiumLibraryPath, true, nullptr );
kicadPlugin.FootprintEnumerate( kicadFootprintNames, kicadLibraryPath, true, nullptr );
BOOST_CHECK_EQUAL( altiumFootprintNames.GetCount(), kicadFootprintNames.GetCount() );
for( size_t i = 0; i < altiumFootprintNames.GetCount(); i++ )
{ {
wxString altiumLibraryPath = dataPath + libName.first; wxString footprintName = altiumFootprintNames[i];
wxString kicadLibraryPath = dataPath + libName.second;
wxArrayString altiumFootprintNames; BOOST_TEST_CONTEXT( wxString::Format( wxT( "Import '%s' from '%s'" ), footprintName,
wxArrayString kicadFootprintNames; altiumLibraryName ) )
altiumPlugin.FootprintEnumerate( altiumFootprintNames, altiumLibraryPath, true, nullptr );
kicadPlugin.FootprintEnumerate( kicadFootprintNames, kicadLibraryPath, true, nullptr );
BOOST_CHECK_EQUAL( altiumFootprintNames.GetCount(), kicadFootprintNames.GetCount() );
for( size_t i = 0; i < altiumFootprintNames.GetCount(); i++ )
{ {
wxString footprintName = altiumFootprintNames[i]; FOOTPRINT* altiumFp = altiumPlugin.FootprintLoad( altiumLibraryPath, footprintName,
false, nullptr );
BOOST_CHECK( altiumFp );
BOOST_TEST_CONTEXT( wxString::Format( wxT( "Import '%s' from '%s'" ), footprintName, BOOST_CHECK_EQUAL( "REF**", altiumFp->GetReference() );
libName.first ) ) BOOST_CHECK_EQUAL( footprintName, altiumFp->GetValue() );
{
FOOTPRINT* altiumFp = altiumPlugin.FootprintLoad( altiumLibraryPath, footprintName,
false, nullptr );
BOOST_CHECK( altiumFp );
BOOST_CHECK_EQUAL( "REF**", altiumFp->GetReference() ); FOOTPRINT* kicadFp = kicadPlugin.FootprintLoad( kicadLibraryPath, footprintName,
BOOST_CHECK_EQUAL( footprintName, altiumFp->GetValue() ); true, nullptr );
BOOST_CHECK( kicadFp );
FOOTPRINT* kicadFp = kicadPlugin.FootprintLoad( kicadLibraryPath, footprintName, KI_TEST::CheckFootprint( kicadFp, altiumFp );
true, nullptr );
BOOST_CHECK( kicadFp );
KI_TEST::CheckFootprint( kicadFp, altiumFp );
}
} }
} }
} }
BOOST_AUTO_TEST_SUITE_END() BOOST_AUTO_TEST_SUITE_END()