haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't start dragging unselected zones from their filled areas 

Fixes https://gitlab.com/kicad/code/kicad/-/issues/6795
This commit is contained in:
Jon Evans 2020-12-20 10:41:02 -05:00
parent 0830f87ef4
commit a6e595dbda
1 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
pcbnew/tools/pcb_selection_tool.cpp
View File

@ -346,9 +346,34 @@ int PCB_SELECTION_TOOL::Main( const TOOL_EVENT& aEvent )
} }
else else
{ {
// Don't allow starting a drag from a zone filled area that isn't already selected
auto zoneFilledAreaFilter =
[]( const VECTOR2I& aWhere, GENERAL_COLLECTOR& aCollector,
PCB_SELECTION_TOOL* aTool )
{
wxPoint location = wxPoint( aWhere );
int accuracy = KiROUND( 5 * aCollector.GetGuide()->OnePixelInIU() );
std::set<EDA_ITEM*> remove;
for( EDA_ITEM* item : aCollector )
{
if( item->Type() == PCB_ZONE_T )
{
ZONE* zone = static_cast<ZONE*>( item );
if( !zone->HitTestForCorner( location, accuracy * 2 ) &&
!zone->HitTestForEdge( location, accuracy ) )
remove.insert( zone );
}
}
for( EDA_ITEM* item : remove )
aCollector.Remove( item );
};
// Selection is empty? try to start dragging the item under the point where drag // Selection is empty? try to start dragging the item under the point where drag
// started // started
if( m_selection.Empty() && selectCursor() ) if( m_selection.Empty() && selectCursor( false, zoneFilledAreaFilter ) )
m_selection.SetIsHover( true ); m_selection.SetIsHover( true );
// Check if dragging has started within any of selected items bounding box. // Check if dragging has started within any of selected items bounding box.