haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a compil warning. 

Fix also an incorrect comment.
This commit is contained in:
jean-pierre charras 2023-09-14 15:19:46 +02:00
parent c7e865e4a2
commit a7b1448ccd
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
3d-viewer/3d_canvas/board_adapter.h
View File

@ -351,7 +351,7 @@ private:
void createPadWithMargin( const PAD *aPad, CONTAINER_2D_BASE* aDstContainer, void createPadWithMargin( const PAD *aPad, CONTAINER_2D_BASE* aDstContainer,
PCB_LAYER_ID aLayer, const VECTOR2I& aMargin ) const; PCB_LAYER_ID aLayer, const VECTOR2I& aMargin ) const;
OBJECT_2D* createPadWithHole( const PAD* aPad, CONTAINER_2D_BASE* aDstContainer, void createPadWithHole( const PAD* aPad, CONTAINER_2D_BASE* aDstContainer,
int aInflateValue ); int aInflateValue );
void addPads( const FOOTPRINT* aFootprint, CONTAINER_2D_BASE* aDstContainer, void addPads( const FOOTPRINT* aFootprint, CONTAINER_2D_BASE* aDstContainer,

4
3d-viewer/3d_canvas/create_3Dgraphic_brd_items.cpp
View File

@ -467,13 +467,13 @@ void BOARD_ADAPTER::createPadWithMargin( const PAD* aPad, CONTAINER_2D_BASE* aCo
} }
OBJECT_2D* BOARD_ADAPTER::createPadWithHole( const PAD* aPad, CONTAINER_2D_BASE* aDstContainer, void BOARD_ADAPTER::createPadWithHole( const PAD* aPad, CONTAINER_2D_BASE* aDstContainer,
int aInflateValue ) int aInflateValue )
{ {
if( !aPad->HasHole() ) if( !aPad->HasHole() )
{ {
wxLogTrace( m_logTrace, wxT( "BOARD_ADAPTER::createPadWithHole - found an invalid pad" ) ); wxLogTrace( m_logTrace, wxT( "BOARD_ADAPTER::createPadWithHole - found an invalid pad" ) );
return nullptr; return;
} }
std::shared_ptr<SHAPE_SEGMENT> slot = aPad->GetEffectiveHoleShape(); std::shared_ptr<SHAPE_SEGMENT> slot = aPad->GetEffectiveHoleShape();

2
pcbnew/pcb_track.cpp
View File

@ -1177,7 +1177,7 @@ bool PCB_ARC::IsDegenerated( int aThreshold ) const
// cannot be safely computed if the distance between mid and end points // cannot be safely computed if the distance between mid and end points
// is too small (a few internal units) // is too small (a few internal units)
// len of both segments must be >= aThreshold to be not Degenerated arc // len of both segments must be < aThreshold to be a very small degenerated arc
return ( GetMid() - GetStart() ).EuclideanNorm() < aThreshold return ( GetMid() - GetStart() ).EuclideanNorm() < aThreshold
&& ( GetMid() - GetEnd() ).EuclideanNorm() < aThreshold; && ( GetMid() - GetEnd() ).EuclideanNorm() < aThreshold;
} }