haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a few minor compil and Coverity warnings.

This commit is contained in:
jean-pierre charras 2023-08-17 17:32:11 +02:00
parent 43fe1eec84
commit a7e74bf4bc
4 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
eeschema/dialogs/dialog_erc.cpp
View File

@ -476,7 +476,6 @@ void DIALOG_ERC::testErc()
SCHEMATIC* sch = &m_parent->Schematic(); SCHEMATIC* sch = &m_parent->Schematic();
SCH_SCREENS screens( sch->Root() ); SCH_SCREENS screens( sch->Root() );
ERC_SETTINGS& settings = sch->ErcSettings();
ERC_TESTER tester( sch ); ERC_TESTER tester( sch );
{ {

4
pcbnew/footprint_libraries_utils.cpp
View File

@ -133,9 +133,7 @@ FOOTPRINT* FOOTPRINT_EDIT_FRAME::ImportFootprint( const wxString& aName )
if( !fn.IsOk() ) if( !fn.IsOk() )
return nullptr; return nullptr;
FILE* fp = wxFopen( fn.GetFullPath(), wxT( "rt" ) ); if( !wxFileExists( fn.GetFullPath() ) )
if( !fp )
{ {
wxString msg = wxString::Format( _( "File '%s' not found." ), fn.GetFullPath() ); wxString msg = wxString::Format( _( "File '%s' not found." ), fn.GetFullPath() );
DisplayError( this, msg ); DisplayError( this, msg );

12
pcbnew/plugin.cpp
View File

@ -67,9 +67,9 @@ bool PLUGIN::CanReadBoard( const wxString& aFileName ) const
wxString fileExt = wxFileName( aFileName ).GetExt().MakeLower(); wxString fileExt = wxFileName( aFileName ).GetExt().MakeLower();
for( const wxString& ext : exts ) for( const std::string& ext : exts )
{ {
if( fileExt == ext.Lower() ) if( fileExt == wxString( ext ).Lower() )
return true; return true;
} }
@ -83,9 +83,9 @@ bool PLUGIN::CanReadFootprint( const wxString& aFileName ) const
wxString fileExt = wxFileName( aFileName ).GetExt().MakeLower(); wxString fileExt = wxFileName( aFileName ).GetExt().MakeLower();
for( const wxString& ext : exts ) for( const std::string& ext : exts )
{ {
if( fileExt == ext.Lower() ) if( fileExt == wxString( ext ).Lower() )
return true; return true;
} }
@ -103,9 +103,9 @@ bool PLUGIN::CanReadFootprintLib( const wxString& aFileName ) const
wxString fileExt = wxFileName( aFileName ).GetExt().MakeLower(); wxString fileExt = wxFileName( aFileName ).GetExt().MakeLower();
for( const wxString& ext : exts ) for( const std::string& ext : exts )
{ {
if( fileExt == ext.Lower() ) if( fileExt == wxString( ext ).Lower() )
return true; return true;
} }
} }

1
pcbnew/plugins/legacy/legacy_plugin.cpp
View File

@ -437,7 +437,6 @@ bool LEGACY_PLUGIN::CanReadFootprint( const wxString& aFileName ) const
FILE_LINE_READER freader( aFileName ); FILE_LINE_READER freader( aFileName );
WHITESPACE_FILTER_READER reader( freader ); WHITESPACE_FILTER_READER reader( freader );
IO_MGR::PCB_FILE_T file_type;
reader.ReadLine(); reader.ReadLine();
char* line = reader.Line(); char* line = reader.Line();