haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QA: Remove helper function 

The InOutString function is not really useful, in most cases it can
be done more simple with string operator+. This function is causing
issues on MSVC (perhaps the template param names) anyway.
This commit is contained in:
John Beard 2019-05-24 10:24:14 +01:00
parent 816f6db310
commit a88ac393bb
2 changed files with 1 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qa/common/libeval/test_numeric_evaluator.cpp
View File

@ -160,7 +160,7 @@ BOOST_AUTO_TEST_CASE( Results )
{ {
for( const auto& c : eval_cases_valid ) for( const auto& c : eval_cases_valid )
{ {
BOOST_TEST_CONTEXT( KI_TEST::InOutString( c.input, c.exp_result ) ) BOOST_TEST_CONTEXT( c.input + " -> " + c.exp_result )
{ {
// Clear for new string input // Clear for new string input
m_eval.Clear(); m_eval.Clear();

20
qa/unit_test_utils/include/unit_test_utils/unit_test_utils.h
View File

@ -284,26 +284,6 @@ bool CollectionHasNoDuplicates( const T& aCollection )
} }
/**
* Get a simple string "aIn -> aOut".
*
* Useful for BOOST_TEST_CONTEXT blocks as a brief description where a full
* case name would be a bit too much.
*
* @tparam IN the input type
* @tparam OUT the output type
* @param aIn the input
* @param aOut the output
* @return "aIn -> aOut"
*/
template<typename IN, typename OUT>
std::string InOutString( const IN& aIn, const OUT& aOut )
{
std::stringstream ss;
ss << aIn << " -> " << aOut;
return ss.str();
}
/** /**
* A test macro to check a wxASSERT is thrown. * A test macro to check a wxASSERT is thrown.
* *