haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Handle small holes in DRC Connection width test 

If there is a small hole (smaller than the conn width), we can loop
around in a circle checking all points and not move past the mimimum
distance.

To avoid this, if we detect a loop, we exit the substantial checker.
This should return with true because a large hole will return true and
we are only checking to see if there is a minimum amount of copper
between two open areas

(cherry picked from commit c841d0df6d)
This commit is contained in:
Seth Hillbrand 2024-03-30 07:45:51 -07:00
parent 4bf35cbed8
commit ae11213622
1 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
pcbnew/drc/drc_test_provider_connection_width.cpp
View File

@ -335,13 +335,13 @@ private:
// a new fracture point, then we know that we are proceeding // a new fracture point, then we know that we are proceeding
// in the wrong direction from the fracture and should // in the wrong direction from the fracture and should
// fall through to the next point // fall through to the next point
if( same_point( aPt, nz ) if( same_point( aPt, nz ) && same_point( aPt->next, nz->prev )
&& aPt->y == aPt->next->y ) && aPt->y == aPt->next->y )
{ {
return nz->next; return nz->next;
} }
if( same_point( aPt, pz ) if( same_point( aPt, pz ) && same_point( aPt->next, pz->prev )
&& aPt->y == aPt->next->y ) && aPt->y == aPt->next->y )
{ {
return pz->next; return pz->next;
@ -399,14 +399,16 @@ private:
const Vertex* p0 = aA; const Vertex* p0 = aA;
const Vertex* p = getNextOutlineVertex( p0 ); const Vertex* p = getNextOutlineVertex( p0 );
while( !same_point( p, aB ) && checked < total_pts && !( x_change && y_change ) ) while( !same_point( p, aB ) // We've reached the other inflection point
&& !same_point( p, aA ) // We've gone around in a circle
&& checked < total_pts // Fail-safe for invalid lists
&& !( x_change && y_change ) ) // We've found a substantial change in both directions
{ {
double diff_x = std::abs( p->x - p0->x ); double diff_x = std::abs( p->x - p0->x );
double diff_y = std::abs( p->y - p0->y ); double diff_y = std::abs( p->y - p0->y );
// Floating point zeros can have a negative sign, so we need to // Check for a substantial change in the x or y direction
// ensure that only substantive diversions count for a direction // This is measured by the set value of the minimum connection width
// change
if( diff_x > m_limit ) if( diff_x > m_limit )
x_change = true; x_change = true;
@ -420,7 +422,7 @@ private:
wxCHECK_MSG( checked < total_pts, false, wxT( "Invalid polygon detected. Missing points to check" ) ); wxCHECK_MSG( checked < total_pts, false, wxT( "Invalid polygon detected. Missing points to check" ) );
if( !x_change || !y_change ) if( !same_point( p, aA ) && ( !x_change || !y_change ) )
return false; return false;
p = getPrevOutlineVertex( p0 ); p = getPrevOutlineVertex( p0 );
@ -429,7 +431,10 @@ private:
y_change = false; y_change = false;
checked = 0; checked = 0;
while( !same_point( p, aB ) && checked < total_pts && !( x_change && y_change ) ) while( !same_point( p, aB ) // We've reached the other inflection point
&& !same_point( p, aA ) // We've gone around in a circle
&& checked < total_pts // Fail-safe for invalid lists
&& !( x_change && y_change ) ) // We've found a substantial change in both directions
{ {
double diff_x = std::abs( p->x - p0->x ); double diff_x = std::abs( p->x - p0->x );
double diff_y = std::abs( p->y - p0->y ); double diff_y = std::abs( p->y - p0->y );
@ -450,7 +455,7 @@ private:
wxCHECK_MSG( checked < total_pts, false, wxT( "Invalid polygon detected. Missing points to check" ) ); wxCHECK_MSG( checked < total_pts, false, wxT( "Invalid polygon detected. Missing points to check" ) );
return ( x_change && y_change ); return ( same_point( p, aA ) || ( x_change && y_change ) );
} }
/** /**