Fix some warnings.

This commit is contained in:
Alex Shvartzkop 2024-04-14 01:19:39 +03:00
parent c1dc4e1d47
commit affcfed677
5 changed files with 2 additions and 9 deletions

View File

@ -209,7 +209,7 @@ void BACKGROUND_JOB_REPORTER::AdvancePhase()
} }
BACKGROUND_JOBS_MONITOR::BACKGROUND_JOBS_MONITOR() : m_jobListDialog( nullptr ) BACKGROUND_JOBS_MONITOR::BACKGROUND_JOBS_MONITOR()
{ {
} }

View File

@ -130,7 +130,6 @@ FIELDS_GRID_TABLE::FIELDS_GRID_TABLE( DIALOG_SHIM* aDialog, SCH_BASE_FRAME* aFra
LIB_SYMBOL* aSymbol ) : LIB_SYMBOL* aSymbol ) :
m_frame( aFrame ), m_frame( aFrame ),
m_dialog( aDialog ), m_dialog( aDialog ),
m_grid( aGrid ),
m_parentType( SCH_SYMBOL_T ), m_parentType( SCH_SYMBOL_T ),
m_mandatoryFieldCount( MANDATORY_FIELDS ), m_mandatoryFieldCount( MANDATORY_FIELDS ),
m_part( aSymbol ), m_part( aSymbol ),
@ -150,7 +149,6 @@ FIELDS_GRID_TABLE::FIELDS_GRID_TABLE( DIALOG_SHIM* aDialog, SCH_EDIT_FRAME* aFra
SCH_SYMBOL* aSymbol ) : SCH_SYMBOL* aSymbol ) :
m_frame( aFrame ), m_frame( aFrame ),
m_dialog( aDialog ), m_dialog( aDialog ),
m_grid( aGrid ),
m_parentType( SCH_SYMBOL_T ), m_parentType( SCH_SYMBOL_T ),
m_mandatoryFieldCount( MANDATORY_FIELDS ), m_mandatoryFieldCount( MANDATORY_FIELDS ),
m_part( aSymbol->GetLibSymbolRef().get() ), m_part( aSymbol->GetLibSymbolRef().get() ),
@ -170,7 +168,6 @@ FIELDS_GRID_TABLE::FIELDS_GRID_TABLE( DIALOG_SHIM* aDialog, SCH_EDIT_FRAME* aFra
SCH_SHEET* aSheet ) : SCH_SHEET* aSheet ) :
m_frame( aFrame ), m_frame( aFrame ),
m_dialog( aDialog ), m_dialog( aDialog ),
m_grid( aGrid ),
m_parentType( SCH_SHEET_T ), m_parentType( SCH_SHEET_T ),
m_mandatoryFieldCount( SHEET_MANDATORY_FIELDS ), m_mandatoryFieldCount( SHEET_MANDATORY_FIELDS ),
m_part( nullptr ), m_part( nullptr ),
@ -189,7 +186,6 @@ FIELDS_GRID_TABLE::FIELDS_GRID_TABLE( DIALOG_SHIM* aDialog, SCH_EDIT_FRAME* aFra
SCH_LABEL_BASE* aLabel ) : SCH_LABEL_BASE* aLabel ) :
m_frame( aFrame ), m_frame( aFrame ),
m_dialog( aDialog ), m_dialog( aDialog ),
m_grid( aGrid ),
m_parentType( SCH_LABEL_LOCATE_ANY_T ), m_parentType( SCH_LABEL_LOCATE_ANY_T ),
m_mandatoryFieldCount( aLabel->GetMandatoryFieldCount() ), m_mandatoryFieldCount( aLabel->GetMandatoryFieldCount() ),
m_part( nullptr ), m_part( nullptr ),

View File

@ -116,7 +116,6 @@ protected:
private: private:
SCH_BASE_FRAME* m_frame; SCH_BASE_FRAME* m_frame;
DIALOG_SHIM* m_dialog; DIALOG_SHIM* m_dialog;
WX_GRID* m_grid;
KICAD_T m_parentType; KICAD_T m_parentType;
int m_mandatoryFieldCount; int m_mandatoryFieldCount;
LIB_SYMBOL* m_part; LIB_SYMBOL* m_part;

View File

@ -52,7 +52,7 @@ DIALOG_SYNC_SHEET_PINS::DIALOG_SYNC_SHEET_PINS( wxWindow* aParent,
wxImageList* imageList = new wxImageList( SYNC_SHEET_PIN_PREFERENCE::NORMAL_WIDTH, wxImageList* imageList = new wxImageList( SYNC_SHEET_PIN_PREFERENCE::NORMAL_WIDTH,
SYNC_SHEET_PIN_PREFERENCE::NORMAL_HEIGHT ); SYNC_SHEET_PIN_PREFERENCE::NORMAL_HEIGHT );
for( const auto [icon_idx, bitmap] : SYNC_SHEET_PIN_PREFERENCE::GetBookctrlPageIcon() ) for( const auto& [icon_idx, bitmap] : SYNC_SHEET_PIN_PREFERENCE::GetBookctrlPageIcon() )
{ {
imageList->Add( KiBitmap( bitmap, SYNC_SHEET_PIN_PREFERENCE::NORMAL_HEIGHT ) ); imageList->Add( KiBitmap( bitmap, SYNC_SHEET_PIN_PREFERENCE::NORMAL_HEIGHT ) );
} }

View File

@ -128,8 +128,6 @@ private:
*/ */
void jobUpdated( std::shared_ptr<BACKGROUND_JOB> aJob ); void jobUpdated( std::shared_ptr<BACKGROUND_JOB> aJob );
BACKGROUND_JOB_LIST* m_jobListDialog;
/** /**
* Holds a reference to all active background jobs * Holds a reference to all active background jobs
* Access to this vector should be protected by locks since threads may Create or Remove at will * Access to this vector should be protected by locks since threads may Create or Remove at will