haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change pad-type-matches-hole-presence from warning to error. 

Fixes https://gitlab.com/kicad/code/kicad/issues/11452
This commit is contained in:
Jeff Young 2022-04-24 14:14:11 +01:00
parent 4cd48cd5c9
commit b04f1b2d93
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pcbnew/dialogs/dialog_pad_properties.cpp
View File

@ -1345,7 +1345,7 @@ bool DIALOG_PAD_PROPERTIES::padValuesOK()
}
if( error )
error_msgs.Add( _( "Too large value for pad delta size." ) );
error_msgs.Add( _( "Error: Trapazoid delta is too large." ) );
switch( m_dummyPad->GetAttribute() )
{
@ -1354,20 +1354,25 @@ bool DIALOG_PAD_PROPERTIES::padValuesOK()
if( drill_size.x <= 0
|| ( drill_size.y <= 0 && m_dummyPad->GetDrillShape() == PAD_DRILL_SHAPE_OBLONG ) )
{
warning_msgs.Add( _( "Warning: Through hole pad has no hole." ) );
error_msgs.Add( _( "Error: Through hole pad has no hole." ) );
}
break;
case PAD_ATTRIB::CONN: // Connector pads are smd pads, just they do not have solder paste.
if( padlayers_mask[B_Paste] || padlayers_mask[F_Paste] )
{
warning_msgs.Add( _( "Warning: Connector pads normally have no solder paste. Use an "
warning_msgs.Add( _( "Warning: Connector pads normally have no solder paste. Use a "
"SMD pad instead." ) );
}
KI_FALLTHROUGH;
case PAD_ATTRIB::SMD: // SMD and Connector pads (One external copper layer only)
{
if( drill_size.x > 0 || drill_size.y > 0 )
{
error_msgs.Add( _( "Error: SMD pad has a hole." ) );
}
LSET innerlayers_mask = padlayers_mask & LSET::InternalCuMask();
if( ( padlayers_mask[F_Cu] && padlayers_mask[B_Cu] ) || innerlayers_mask.count() != 0 )