haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cache works better with unique keys

This commit is contained in:
Jon Evans 2022-09-01 23:11:09 -04:00
parent 854acd4c77
commit b0aba0fdf3
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
common/database/database_connection.cpp
View File

@ -322,6 +322,8 @@ bool DATABASE_CONNECTION::SelectOne( const std::string& aTable,
const std::string& columnName = columnCacheIter->first; const std::string& columnName = columnCacheIter->first;
std::string cacheKey = fmt::format( "{}{}{}", tableName, columnName, aWhere.second );
std::string queryStr = fmt::format( "SELECT * FROM {}{}{} WHERE {}{}{} = ?", std::string queryStr = fmt::format( "SELECT * FROM {}{}{} WHERE {}{}{} = ?",
m_quoteChar, tableName, m_quoteChar, m_quoteChar, tableName, m_quoteChar,
m_quoteChar, columnName, m_quoteChar ); m_quoteChar, columnName, m_quoteChar );
@ -329,7 +331,7 @@ bool DATABASE_CONNECTION::SelectOne( const std::string& aTable,
nanodbc::statement statement( *m_conn ); nanodbc::statement statement( *m_conn );
nanodbc::string query = fromUTF8( queryStr ); nanodbc::string query = fromUTF8( queryStr );
if( m_cache->Get( queryStr, aResult ) ) if( m_cache->Get( cacheKey, aResult ) )
{ {
wxLogTrace( traceDatabase, wxT( "SelectOne: `%s` with parameter `%s` - cache hit" ), wxLogTrace( traceDatabase, wxT( "SelectOne: `%s` with parameter `%s` - cache hit" ),
toUTF8( query ), aWhere.second ); toUTF8( query ), aWhere.second );
@ -393,7 +395,7 @@ bool DATABASE_CONNECTION::SelectOne( const std::string& aTable,
return false; return false;
} }
m_cache->Put( queryStr, aResult ); m_cache->Put( cacheKey, aResult );
return true; return true;
} }