haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Eeschema: Check for NULL pointer when using interactive delete tool 

CHANGED: If you start the interactive delete tool and the mouse pointer
isn't near anything, Eeschema tries to use a null EDA_ITEM pointer
which throws an exception.  This commit checks if the pointer is null
and exits if it is.
This commit is contained in:
PJM 2020-09-29 19:28:23 -07:00 committed by Ian McInerney
parent e7c31f5dba
commit b0e05ad9bf
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
eeschema/tools/ee_selection_tool.cpp
View File

@ -726,18 +726,21 @@ void EE_SELECTION_TOOL::GuessSelectionCandidates( EE_COLLECTOR& collector, const
} }
} }
EDA_RECT tightBox = closest->GetBoundingBox(); if( closest ) // Don't try and get a tight bbox if nothing is near the mouse pointer
tightBox.Inflate( -tightBox.GetWidth() / 4, -tightBox.GetHeight() / 4 );
for( int i = collector.GetCount() - 1; i >= 0; --i )
{ {
EDA_ITEM* item = collector[ i ]; EDA_RECT tightBox = closest->GetBoundingBox();
tightBox.Inflate( -tightBox.GetWidth() / 4, -tightBox.GetHeight() / 4 );
if( item == closest ) for( int i = collector.GetCount() - 1; i >= 0; --i )
continue; {
EDA_ITEM* item = collector[i];
if( !item->HitTest( tightBox, true ) ) if( item == closest )
collector.Transfer( item ); continue;
if( !item->HitTest( tightBox, true ) )
collector.Transfer( item );
}
} }
} }