haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

SELECTION: fixed pointer arithmetic-related segfault in operator[]

This commit is contained in:
Tomasz Włostowski 2016-12-20 11:29:28 +01:00 committed by Maciej Suminski
parent 3ffa37c8b9
commit b20323dc63
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pcbnew/tools/selection_tool.h
View File

@ -89,8 +89,7 @@ public:
{
auto iter = m_items.begin();
while( idx-- )
++iter;
std::advance( iter, idx );
return *iter;
}
@ -120,12 +119,14 @@ public:
/// Returns the center point of the selection area bounding box.
VECTOR2I GetCenter() const;
BOARD_ITEM *operator[] ( const int index ) const
BOARD_ITEM* operator[]( const int index ) const
{
if ( index < 0 || (unsigned int) index >= m_items.size() )
if( index < 0 || (unsigned int) index >= m_items.size() )
return nullptr;
return (* m_items.begin() + index );
auto iter = m_items.begin();
std::advance( iter, index );
return *iter;
}
BOARD_ITEM* Front() const