haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Suppress leaking eda_item so much via undo_redo_container.h

This commit is contained in:
Marek Roszko 2021-06-07 22:29:33 -04:00
parent 20134e4a1b
commit b2f5c989a6
4 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
common/undo_redo_container.cpp
View File

@ -58,10 +58,18 @@ ITEM_PICKER::ITEM_PICKER( BASE_SCREEN* aScreen, EDA_ITEM* aItem, UNDO_REDO aUndo
}
void ITEM_PICKER::SetItem( EDA_ITEM* aItem )
{
m_pickedItem = aItem;
m_pickedItemType = aItem ? aItem->Type() : TYPE_NOT_INIT;
}
PICKED_ITEMS_LIST::PICKED_ITEMS_LIST()
{
}
PICKED_ITEMS_LIST::~PICKED_ITEMS_LIST()
{
}

2
include/commit.h
View File

@ -30,7 +30,7 @@
#include <set>
#include <vector>
#include <wx/string.h>
#include <undo_redo_container.h>
class EDA_ITEM;

2
include/eda_draw_frame.h
View File

@ -32,8 +32,10 @@
#include <gal/color4d.h>
#include <class_draw_panel_gal.h>
#include <origin_transforms.h>
#include <kiid.h>
#include "hotkeys_basic.h"
class EDA_ITEM;
class wxSingleInstanceChecker;
class ACTION_TOOLBAR;
class COLOR_SETTINGS;

14
include/undo_redo_container.h
View File

@ -25,14 +25,16 @@
#ifndef _CLASS_UNDOREDO_CONTAINER_H
#define _CLASS_UNDOREDO_CONTAINER_H
#include <core/typeinfo.h>
#include <vector>
#include <eda_item.h>
class EDA_ITEM;
class PICKED_ITEMS_LIST;
class BASE_SCREEN;
// forward declaration to avoid eda_item.h for now
typedef unsigned STATUS_FLAGS;
/**
* Undo Redo considerations:
@ -82,11 +84,7 @@ public:
EDA_ITEM* GetItem() const { return m_pickedItem; }
void SetItem( EDA_ITEM* aItem )
{
m_pickedItem = aItem;
m_pickedItemType = aItem ? aItem->Type() : TYPE_NOT_INIT;
}
void SetItem( EDA_ITEM* aItem );
KICAD_T GetItemType() const { return m_pickedItemType; }