haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Always store via drill value in .kicad_pcb file. 

Old boards were using UNDEFINED_DRILL_DIAMETER value in file for via drill when
the via drill value was the netclass value.
Recent boards always set the via drill to the actual value, but now we need
to be sure always store the drill value, because netclass value is not stored
in the board file. Otherwise the drill value of some (old) vias can be unknown
This commit is contained in:
jean-pierre charras 2021-02-26 20:24:59 +01:00
parent 73dd93701a
commit b31bf1e40f
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pcbnew/plugins/kicad/kicad_plugin.cpp
View File

@ -1749,8 +1749,15 @@ void PCB_IO::format( const TRACK* aTrack, int aNestLevel ) const
FormatInternalUnits( aTrack->GetStart() ).c_str(),
FormatInternalUnits( aTrack->GetWidth() ).c_str() );
// Old boards were using UNDEFINED_DRILL_DIAMETER value in file for via drill when
// via drill was the netclass value.
// recent boards always set the via drill to the actual value, but now we need to
// always store the drill value, because netclass value is not stored in the board file.
// Otherwise the drill value of some (old) vias can be unknown
if( via->GetDrill() != UNDEFINED_DRILL_DIAMETER )
m_out->Print( 0, " (drill %s)", FormatInternalUnits( via->GetDrill() ).c_str() );
else // Probably old board!
m_out->Print( 0, " (drill %s)", FormatInternalUnits( via->GetDrillValue() ).c_str() );
m_out->Print( 0, " (layers %s %s)",
m_out->Quotew( LSET::Name( layer1 ) ).c_str(),