haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Altium: Don't load library parameters with an owner for now 

In Altium many objects can have parameters (including pins). For now
we will drop library parameters belonging to any sub-components of a
symbol.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/17048

(cherry picked from commit 1a6e6a06eb)
This commit is contained in:
Roberto Fernandez Bautista 2024-02-22 19:23:39 +01:00
parent ad311c33c6
commit b3b6637b44
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
eeschema/sch_io/altium/sch_io_altium.cpp
View File

@ -3783,11 +3783,18 @@ void SCH_IO_ALTIUM::ParseLibParameter( const std::map<wxString, wxString>& aProp
{ {
ASCH_PARAMETER elem( aProperties ); ASCH_PARAMETER elem( aProperties );
// Part ID 1 is the current library part. Part ID -1 means all parts // Part ID 1 is the current library part.
// Part ID ALTIUM_COMPONENT_NONE(-1) means all parts
// If a parameter is assigned to a specific element such as a pin, // If a parameter is assigned to a specific element such as a pin,
// we will need to handle it here. // we will need to handle it here.
// TODO: Handle HIDDENNETNAME property (others?) // TODO: Handle HIDDENNETNAME property (others?)
if( elem.ownerpartid != 1 && elem.ownerpartid != -1 ) if( elem.ownerpartid != 1 && elem.ownerpartid != ALTIUM_COMPONENT_NONE )
return;
// If ownerindex is populated, this is parameter belongs to a subelement (e.g. pin).
// Ignore for now.
// TODO: Update this when KiCad supports parameters for any object
if( elem.ownerindex != ALTIUM_COMPONENT_NONE )
return; return;
// TODO: fill in replacements from variant, sheet and project // TODO: fill in replacements from variant, sheet and project