haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DRC: fix one of some things that can create false positive. 

in bool shapeNeedsUpdate(), if a shape is a rectangle and the other is a polygon,
we need to try to convert the polygon to a rectangle for comparison, because some
transforms ( and especially PCB_SHAPE::Normalize() ) can convert a polygon to a rectangle
So a poly and a rectangle can be in fact the same shape

Partial fix of bug 16075.
This commit is contained in:
jean-pierre charras 2023-11-12 20:19:09 +01:00
parent 9f0d409982
commit b564d0713c
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
pcbnew/drc/drc_test_provider_library_parity.cpp
View File

@ -352,6 +352,27 @@ bool padNeedsUpdate( const PAD* a, const PAD* b, REPORTER* aReporter )
bool shapeNeedsUpdate( const PCB_SHAPE* a, const PCB_SHAPE* b )
{
// Preliminary test: if a shape is a rectangle and the other is a polygon,
// try to convert the polygon to a rectangle for comparison, because some transforms
// ( and especially PCB_SHAPE::Normalize() ) can convert a polygon to a rectangle
// So a poly and a rectangle can be in fact the same shape
if( a->GetShape() == SHAPE_T::POLY && b->GetShape() == SHAPE_T::RECTANGLE )
{
PCB_SHAPE rect_test( *a );
rect_test.Normalize();
if( rect_test.GetShape() == SHAPE_T::RECTANGLE )
return shapeNeedsUpdate( &rect_test, b );
}
else if( a->GetShape() == SHAPE_T::RECTANGLE && b->GetShape() == SHAPE_T::POLY )
{
PCB_SHAPE rect_test( *b );
rect_test.Normalize();
if( rect_test.GetShape() == SHAPE_T::RECTANGLE )
return shapeNeedsUpdate( a, &rect_test );
}
REPORTER* aReporter = nullptr;
bool diff = false;