haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pcbnew: Added missing DRC checks for value and library-link between symbol and footprint

This commit is contained in:
Jan Wichmann 2024-01-24 12:35:51 +00:00 committed by Jeff Young
parent 7cf861a239
commit b6ddef7162
1 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
pcbnew/drc/drc_test_provider_schematic_parity.cpp
View File

@ -125,6 +125,36 @@ void DRC_TEST_PROVIDER_SCHEMATIC_PARITY::testNetlist( NETLIST& aNetlist )
} }
else else
{ {
if( component->GetValue() != footprint->GetValue()
&& !m_drcEngine->IsErrorLimitExceeded( DRCE_SCHEMATIC_PARITY_ISSUES ) )
{
wxString msg;
msg.Printf( _( "Footprint %s value (%s) doesn't match symbol value (%s)." ),
footprint->GetReference(), footprint->GetValue(),
component->GetValue() );
std::shared_ptr<DRC_ITEM> drcItem =
DRC_ITEM::Create( DRCE_SCHEMATIC_PARITY_ISSUES );
drcItem->SetErrorMessage( msg );
drcItem->SetItems( footprint );
reportViolation( drcItem, footprint->GetPosition(), UNDEFINED_LAYER );
}
if( component->GetFPID().GetUniStringLibId() != footprint->GetFPID().GetUniStringLibId()
&& !m_drcEngine->IsErrorLimitExceeded( DRCE_SCHEMATIC_PARITY_ISSUES ) )
{
wxString msg;
msg.Printf( _( "%s footprint (%s) doesn't match that given by symbol (%s)." ),
footprint->GetReference(), footprint->GetFPID().GetUniStringLibId(),
component->GetFPID().GetUniStringLibId() );
std::shared_ptr<DRC_ITEM> drcItem =
DRC_ITEM::Create( DRCE_SCHEMATIC_PARITY_ISSUES );
drcItem->SetErrorMessage( msg );
drcItem->SetItems( footprint );
reportViolation( drcItem, footprint->GetPosition(), UNDEFINED_LAYER );
}
if( ( component->GetProperties().count( "dnp" ) > 0 ) if( ( component->GetProperties().count( "dnp" ) > 0 )
!= ( ( footprint->GetAttributes() & FP_DNP ) > 0 ) != ( ( footprint->GetAttributes() & FP_DNP ) > 0 )
&& !m_drcEngine->IsErrorLimitExceeded( DRCE_SCHEMATIC_PARITY_ISSUES ) ) && !m_drcEngine->IsErrorLimitExceeded( DRCE_SCHEMATIC_PARITY_ISSUES ) )