haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Decrease allowed coverage ration when zones are involved. 

A perfect solution would create holes in the coverage map
for the zone edges and handles, but that's a lot more
work.

Fixes: lp:1773204
* https://bugs.launchpad.net/kicad/+bug/1773204
This commit is contained in:
Jeff Young 2018-05-25 12:58:43 +01:00
parent 61597db12d
commit b89f6d4af3
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pcbnew/tools/selection_tool.cpp
View File

@ -2050,6 +2050,12 @@ void SELECTION_TOOL::guessSelectionCandidates( GENERAL_COLLECTOR& aCollector ) c
double maxArea = calcMaxArea( aCollector, PCB_MODULE_T ); double maxArea = calcMaxArea( aCollector, PCB_MODULE_T );
BOX2D viewportD = getView()->GetViewport(); BOX2D viewportD = getView()->GetViewport();
BOX2I viewport( VECTOR2I( viewportD.GetPosition() ), VECTOR2I( viewportD.GetSize() ) ); BOX2I viewport( VECTOR2I( viewportD.GetPosition() ), VECTOR2I( viewportD.GetSize() ) );
double maxCoverRatio = footprintMaxCoverRatio;
// MODULE::CoverageRatio() doesn't take zone handles & borders into account so just
// use a more aggressive cutoff point if zones are involved.
if( aCollector.CountType( PCB_ZONE_AREA_T ) )
maxCoverRatio /= 2;
for( int i = 0; i < aCollector.GetCount(); ++i ) for( int i = 0; i < aCollector.GetCount(); ++i )
{ {
@ -2060,7 +2066,7 @@ void SELECTION_TOOL::guessSelectionCandidates( GENERAL_COLLECTOR& aCollector ) c
rejected.insert( mod ); rejected.insert( mod );
// footprints completely covered with other features have no other // footprints completely covered with other features have no other
// means of selection, so must be kept // means of selection, so must be kept
else if( mod->CoverageRatio( aCollector ) > footprintMaxCoverRatio ) else if( mod->CoverageRatio( aCollector ) > maxCoverRatio )
rejected.erase( mod ); rejected.erase( mod );
// if a footprint is much smaller than the largest overlapping // if a footprint is much smaller than the largest overlapping
// footprint then it should be considered for selection // footprint then it should be considered for selection