haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix pad selection requirements in footprint editor 

Fixes: lp:1757295
* https://bugs.launchpad.net/kicad/+bug/1757295
This commit is contained in:
Jon Evans 2018-03-20 21:14:57 -04:00
parent b53ed148f3
commit b9ce203487
1 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
pcbnew/tools/selection_tool.cpp
View File

@ -1666,12 +1666,44 @@ bool SELECTION_TOOL::selectable( const BOARD_ITEM* aItem ) const
// When editing modules, it's allowed to select them, even when
// locked, since you already have to explicitly activate the
// module editor to get to this stage
if ( !m_editModules )
if( !m_editModules )
{
MODULE* mod = static_cast<const D_PAD*>( aItem )->GetParent();
if( mod && mod->IsLocked() )
return false;
}
else if( aItem->Type() == PCB_PAD_T )
{
// In editor, pads are selectable if any draw layer is visible
auto pad = static_cast<const D_PAD*>( aItem );
// Shortcut: check copper layer visibility
if( board()->IsLayerVisible( F_Cu ) && pad->IsOnLayer( F_Cu ) )
return true;
if( board()->IsLayerVisible( B_Cu ) && pad->IsOnLayer( B_Cu ) )
return true;
// Now check the non-copper layers
bool draw_layer_visible = false;
int pad_layers[KIGFX::VIEW::VIEW_MAX_LAYERS], pad_layers_count;
pad->ViewGetLayers( pad_layers, pad_layers_count );
for( int i = 0; i < pad_layers_count; ++i )
{
// NOTE: Only checking the regular layers (not GAL meta-layers)
if( ( ( pad_layers[i] < PCB_LAYER_ID_COUNT ) &&
board()->IsLayerVisible( static_cast<PCB_LAYER_ID>( pad_layers[i] ) ) ) )
{
draw_layer_visible = true;
}
}
return draw_layer_visible;
}
break;
}