haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pcbnew: Avoid spinning up thread when routing 

Our connectivity data threads the ratsnest update based on the number of
nets that have changed.  If we are only changing one net (the case when
routing) then making a full thread to update the net is pointless
because we wait for the thread to finish before continuing.  This spins
that off to an inline lambda for single updates while still making
threads for multiple ratsnest changes.
This commit is contained in:
Seth Hillbrand 2018-10-05 05:15:50 -07:00
parent 2db3f859f7
commit bc02044767
1 changed files with 17 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
pcbnew/connectivity_data.cpp
View File

@ -97,14 +97,7 @@ void CONNECTIVITY_DATA::updateRatsnest()
std::atomic<size_t> nextNet( 1 );
std::atomic<size_t> threadsFinished( 0 );
// We don't want to spin up a new thread for fewer than two nets (overhead costs)
size_t parallelThreadCount = std::min<size_t>(
std::max<size_t>( std::thread::hardware_concurrency(), 2 ),
( numDirty + 1 ) / 2 );
for( size_t ii = 0; ii < parallelThreadCount; ++ii )
{
std::thread t = std::thread( [&nextNet, &threadsFinished, this]()
auto update_lambda = [&nextNet, &threadsFinished, this]()
{
for( size_t i = nextNet.fetch_add( 1 ); i < m_nets.size(); i = nextNet.fetch_add( 1 ) )
{
@ -113,9 +106,23 @@ void CONNECTIVITY_DATA::updateRatsnest()
}
threadsFinished++;
} );
};
t.detach();
// We don't want to spin up a new thread for fewer than two nets (overhead costs)
size_t parallelThreadCount = std::min<size_t>(
std::max<size_t>( std::thread::hardware_concurrency(), 2 ),
( numDirty + 1 ) / 2 );
// This prevents generating a thread for point while routing as we are only
// updating the ratsnest on a single net
if( parallelThreadCount == 1 )
update_lambda();
else
{
for( size_t ii = 0; ii < parallelThreadCount; ++ii )
{
std::thread( update_lambda ).detach();
}
}
// Finalize the ratsnest threads