haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Pcbnew: allows using filled polygons in zones with no outline thickness. 

This option was only available if advanced config "ForceThickZones" was set.
This commit is contained in:
jean-pierre charras 2019-09-06 16:13:41 +02:00
parent cee1873fff
commit bd34348068
4 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
common/advanced_config.cpp
View File

@ -90,11 +90,6 @@ static const wxChar AllowLegacyCanvasInGtk3[] = wxT( "AllowLegacyCanvasInGtk3" )
*/
static const wxChar CoroutineStackSize[] = wxT( "CoroutineStackSize" );
/**
* Draw zones in pcbnew with the stroked outline.
*/
static const wxChar ForceThickZones[] = wxT( "ForceThickZones" );
} // namespace KEYS
@ -175,7 +170,6 @@ ADVANCED_CFG::ADVANCED_CFG()
m_enableSvgImport = false;
m_allowLegacyCanvasInGtk3 = false;
m_realTimeConnectivity = true;
m_forceThickOutlinesInZones = true;
m_coroutineStackSize = AC_STACK::default_stack;
loadFromConfigFile();
@ -223,9 +217,6 @@ void ADVANCED_CFG::loadSettings( wxConfigBase& aCfg )
new PARAM_CFG_INT( true, AC_KEYS::CoroutineStackSize, &m_coroutineStackSize,
AC_STACK::default_stack, AC_STACK::min_stack, AC_STACK::max_stack ) );
configParams.push_back( new PARAM_CFG_BOOL( true, AC_KEYS::ForceThickZones,
&m_forceThickOutlinesInZones, true ) );
wxConfigLoadSetups( &aCfg, configParams );
dumpCfg( configParams );

6
include/advanced_config.h
View File

@ -78,12 +78,6 @@ public:
*/
bool m_realTimeConnectivity;
/**
* Force filled polygons with outlines in zone -- To be removed after testing
* default = true (legacy mode)
*/
bool m_forceThickOutlinesInZones;
/**
* Set the stack size for coroutines
*/

4
pcbnew/dialogs/panel_setup_feature_constraints.cpp
View File

@ -45,10 +45,6 @@ PANEL_SETUP_FEATURE_CONSTRAINTS::PANEL_SETUP_FEATURE_CONSTRAINTS( PAGED_DIALOG*
{
m_Frame = aFrame;
m_BrdSettings = &m_Frame->GetBoard()->GetDesignSettings();
// Temporary option: allows zone fill option only if the advanced config option allow it
if( ADVANCED_CFG::GetCfg().m_forceThickOutlinesInZones )
m_bSizerPolygonFillOption->Show( false );
}

3
pcbnew/zone_filler.cpp
View File

@ -105,9 +105,6 @@ bool ZONE_FILLER::Fill( const std::vector<ZONE_CONTAINER*>& aZones, bool aCheck
auto connectivity = m_board->GetConnectivity();
bool filledPolyWithOutline = not m_board->GetDesignSettings().m_ZoneUseNoOutlineInFill;
if( ADVANCED_CFG::GetCfg().m_forceThickOutlinesInZones )
filledPolyWithOutline = true;
std::unique_lock<std::mutex> lock( connectivity->GetLock(), std::try_to_lock );
if( !lock )