haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Gerber output, aperture macros: better compatibility with old Gerber readers. 

In some macros we are using a circle as primitive (primitive 1).
It needs 4 mandatory prms and one optional (not used by Kicad, always 0) prm.
This not used optional prm can create issues with old Gerber readers, so it is removed now.
Fixes #7047
https://gitlab.com/kicad/code/kicad/issues/7047
This commit is contained in:
jean-pierre charras 2021-01-11 15:18:25 +01:00
parent 686fa35405
commit be542c05f2
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
common/plotters/gbr_plotter_aperture_macros.h
View File

@ -27,7 +27,12 @@
// A aperture macro to define a rounded rect pad shape // A aperture macro to define a rounded rect pad shape
// In many gerber readers, the rotation of the full shape is broken // In many gerber readers, the rotation of the full shape is broken
// so we are using primitives that does not need a rotation // so we are using primitives that does not need a rotation around aperture origin.
// Note also the primitive 1 (circle) can use 4 or 5 parameters
// the 5th parameter is the rotation (not used by Kicad ) around aperture origin and is
// a recent optional parameter and can create compatibility issues with old
// Gerber viewer, so it is not output (default = 0).
#define APER_MACRO_ROUNDRECT_NAME "RoundRect" #define APER_MACRO_ROUNDRECT_NAME "RoundRect"
#define APER_MACRO_ROUNDRECT_HEADER \ #define APER_MACRO_ROUNDRECT_HEADER \
@ -38,10 +43,10 @@
0 Add a 4 corners polygon primitive as box body*\n\ 0 Add a 4 corners polygon primitive as box body*\n\
4,1,4,$2,$3,$4,$5,$6,$7,$8,$9,$2,$3,0*\n\ 4,1,4,$2,$3,$4,$5,$6,$7,$8,$9,$2,$3,0*\n\
0 Add four circle primitives for the rounded corners*\n\ 0 Add four circle primitives for the rounded corners*\n\
1,1,$1+$1,$2,$3,0*\n\ 1,1,$1+$1,$2,$3*\n\
1,1,$1+$1,$4,$5,0*\n\ 1,1,$1+$1,$4,$5*\n\
1,1,$1+$1,$6,$7,0*\n\ 1,1,$1+$1,$6,$7*\n\
1,1,$1+$1,$8,$9,0*\n\ 1,1,$1+$1,$8,$9*\n\
0 Add four rect primitives between the rounded corners*\n\ 0 Add four rect primitives between the rounded corners*\n\
20,1,$1+$1,$2,$3,$4,$5,0*\n\ 20,1,$1+$1,$2,$3,$4,$5,0*\n\
20,1,$1+$1,$4,$5,$6,$7,0*\n\ 20,1,$1+$1,$4,$5,$6,$7,0*\n\
@ -78,8 +83,8 @@
0 Add line between two ends*\n\ 0 Add line between two ends*\n\
20,1,$1,$2,$3,$4,$5,0*\n\ 20,1,$1,$2,$3,$4,$5,0*\n\
0 Add two circle primitives to create the rounded ends*\n\ 0 Add two circle primitives to create the rounded ends*\n\
1,1,$1,$2,$3,0*\n\ 1,1,$1,$2,$3*\n\
1,1,$1,$4,$5,0*%\n" 1,1,$1,$4,$5*%\n"
// A aperture macro to define a trapezoid (polygon) by 4 corners // A aperture macro to define a trapezoid (polygon) by 4 corners
// and a rotation angle // and a rotation angle