haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix log errors in new solder masking checking code.

This commit is contained in:
Jeff Young 2022-07-23 09:26:04 +01:00
parent f41af10007
commit bf5e649e44
2 changed files with 25 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
pcbnew/drc/drc_test_provider_solder_mask.cpp
View File

@ -84,9 +84,8 @@ private:
void testMaskItemAgainstZones( BOARD_ITEM* item, const EDA_RECT& itemBBox, void testMaskItemAgainstZones( BOARD_ITEM* item, const EDA_RECT& itemBBox,
PCB_LAYER_ID refLayer, PCB_LAYER_ID targetLayer ); PCB_LAYER_ID refLayer, PCB_LAYER_ID targetLayer );
bool checkMaskAperture( BOARD_ITEM* aMaskItem, PCB_LAYER_ID aCopperLayer, bool checkMaskAperture( BOARD_ITEM* aMaskItem, BOARD_ITEM* aTestItem, PCB_LAYER_ID aTestLayer,
BOARD_ITEM* aTestItem, int aTestNet, int aTestNet, BOARD_ITEM** aCollidingItem );
BOARD_ITEM** aCollidingItem );
private: private:
DRC_RULE m_bridgeRule; DRC_RULE m_bridgeRule;
@ -329,23 +328,22 @@ bool isNullAperture( BOARD_ITEM* aItem )
// when they expose other copper items having at least two distinct nets. We use a map to record // when they expose other copper items having at least two distinct nets. We use a map to record
// the first net exposed by each mask aperture (on each copper layer). // the first net exposed by each mask aperture (on each copper layer).
bool DRC_TEST_PROVIDER_SOLDER_MASK::checkMaskAperture( BOARD_ITEM* aMaskItem, bool DRC_TEST_PROVIDER_SOLDER_MASK::checkMaskAperture( BOARD_ITEM* aMaskItem, BOARD_ITEM* aTestItem,
PCB_LAYER_ID aCopperLayer, PCB_LAYER_ID aTestLayer, int aTestNet,
BOARD_ITEM* aTestItem, int aTestNet,
BOARD_ITEM** aCollidingItem ) BOARD_ITEM** aCollidingItem )
{ {
wxASSERT( IsCopperLayer( aCopperLayer ) ); if( !IsCopperLayer( aTestLayer ) )
return false;
if( aMaskItem->GetParentFootprint() ) FOOTPRINT* fp = static_cast<FOOTPRINT*>( aMaskItem->GetParentFootprint() );
if( fp && ( fp->GetAttributes() & FP_ALLOW_SOLDERMASK_BRIDGES ) > 0 )
{ {
FOOTPRINT* fp = static_cast<FOOTPRINT*>( aMaskItem->GetParentFootprint() );
// Mask apertures in footprints which allow soldermask bridges are ignored entirely. // Mask apertures in footprints which allow soldermask bridges are ignored entirely.
if( fp->GetAttributes() & FP_ALLOW_SOLDERMASK_BRIDGES ) return false;
return false;
} }
std::pair<BOARD_ITEM*, PCB_LAYER_ID> key = { aMaskItem, aCopperLayer }; std::pair<BOARD_ITEM*, PCB_LAYER_ID> key = { aMaskItem, aTestLayer };
auto ii = m_maskApertureNetMap.find( key ); auto ii = m_maskApertureNetMap.find( key );
@ -386,8 +384,9 @@ void DRC_TEST_PROVIDER_SOLDER_MASK::testItemAgainstItems( BOARD_ITEM* aItem,
// Filter: // Filter:
[&]( BOARD_ITEM* other ) -> bool [&]( BOARD_ITEM* other ) -> bool
{ {
PAD* otherPad = dynamic_cast<PAD*>( other ); FOOTPRINT* itemFP = static_cast<FOOTPRINT*>( aItem->GetParentFootprint() );
int otherNet = -1; PAD* otherPad = dynamic_cast<PAD*>( other );
int otherNet = -1;
if( other->IsConnected() ) if( other->IsConnected() )
otherNet = static_cast<BOARD_CONNECTED_ITEM*>( other )->GetNetCode(); otherNet = static_cast<BOARD_CONNECTED_ITEM*>( other )->GetNetCode();
@ -398,18 +397,15 @@ void DRC_TEST_PROVIDER_SOLDER_MASK::testItemAgainstItems( BOARD_ITEM* aItem,
if( isNullAperture( other ) ) if( isNullAperture( other ) )
return false; return false;
if( aItem->GetParentFootprint() && other->GetParentFootprint() ) if( itemFP && itemFP == other->GetParentFootprint()
&& ( itemFP->GetAttributes() & FP_ALLOW_SOLDERMASK_BRIDGES ) > 0 )
{ {
int attr = static_cast<FOOTPRINT*>( aItem->GetParentFootprint() )->GetAttributes(); return false;
if( attr & FP_ALLOW_SOLDERMASK_BRIDGES )
return false;
} }
if( pad && otherPad && pad->GetParent() == otherPad->GetParent() ) if( pad && otherPad && pad->SameLogicalPadAs( otherPad ) )
{ {
if( pad->SameLogicalPadAs( otherPad ) ) return false;
return false;
} }
BOARD_ITEM* a = aItem; BOARD_ITEM* a = aItem;
@ -479,9 +475,9 @@ void DRC_TEST_PROVIDER_SOLDER_MASK::testItemAgainstItems( BOARD_ITEM* aItem,
// Simple mask apertures aren't associated with copper items, so they only // Simple mask apertures aren't associated with copper items, so they only
// constitute a bridge when they expose other copper items having at least // constitute a bridge when they expose other copper items having at least
// two distinct nets. // two distinct nets.
if( isMaskAperture( aItem ) && otherNet >= 0 ) if( isMaskAperture( aItem ) )
{ {
if( checkMaskAperture( aItem, aRefLayer, other, otherNet, &colliding ) ) if( checkMaskAperture( aItem, other, aRefLayer, otherNet, &colliding ) )
{ {
auto drce = DRC_ITEM::Create( DRCE_SOLDERMASK_BRIDGE ); auto drce = DRC_ITEM::Create( DRCE_SOLDERMASK_BRIDGE );
@ -491,9 +487,9 @@ void DRC_TEST_PROVIDER_SOLDER_MASK::testItemAgainstItems( BOARD_ITEM* aItem,
reportViolation( drce, pos, aTargetLayer ); reportViolation( drce, pos, aTargetLayer );
} }
} }
else if( isMaskAperture( other ) && itemNet >= 0 ) else if( isMaskAperture( other ) )
{ {
if( checkMaskAperture( other, aRefLayer, aItem, itemNet, &colliding ) ) if( checkMaskAperture( other, aItem, aRefLayer, itemNet, &colliding ) )
{ {
auto drce = DRC_ITEM::Create( DRCE_SOLDERMASK_BRIDGE ); auto drce = DRC_ITEM::Create( DRCE_SOLDERMASK_BRIDGE );
@ -578,7 +574,7 @@ void DRC_TEST_PROVIDER_SOLDER_MASK::testMaskItemAgainstZones( BOARD_ITEM* aItem,
// two distinct nets. // two distinct nets.
if( isMaskAperture( aItem ) && zoneNet >= 0 ) if( isMaskAperture( aItem ) && zoneNet >= 0 )
{ {
if( checkMaskAperture( aItem, aTargetLayer, zone, zoneNet, &colliding ) ) if( checkMaskAperture( aItem, zone, aTargetLayer, zoneNet, &colliding ) )
{ {
auto drce = DRC_ITEM::Create( DRCE_SOLDERMASK_BRIDGE ); auto drce = DRC_ITEM::Create( DRCE_SOLDERMASK_BRIDGE );

2
pcbnew/pad.h
View File

@ -158,7 +158,7 @@ public:
bool SameLogicalPadAs( const PAD* other ) const bool SameLogicalPadAs( const PAD* other ) const
{ {
// hide tricks behind sensible API // hide tricks behind sensible API
return GetParent() == other->GetParent() && m_number == other->m_number; return GetParentFootprint() == other->GetParentFootprint() && m_number == other->m_number;
} }
/** /**