haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Suppress false ERC warnings for invisible power pins

This commit is contained in:
Jon Evans 2019-04-07 21:33:47 -04:00
parent e5753b79d4
commit c07de84c05
1 changed files with 25 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
eeschema/connection_graph.cpp
View File

@ -376,6 +376,11 @@ void CONNECTION_GRAPH::updateItemConnectivity( SCH_SHEET_PATH aSheet,
pin->GetDefaultNetName( aSheet ); pin->GetDefaultNetName( aSheet );
pin->ConnectedItems().clear(); pin->ConnectedItems().clear();
// Invisible power pins need to be post-processed later
if( pin->IsPowerConnection() && !pin->IsVisible() )
m_invisible_power_pins.push_back( pin );
connection_map[ pos ].push_back( pin ); connection_map[ pos ].push_back( pin );
m_items.insert( pin ); m_items.insert( pin );
} }
@ -568,18 +573,6 @@ void CONNECTION_GRAPH::buildConnectionGraph()
connection->SetSubgraphCode( subgraph->m_code ); connection->SetSubgraphCode( subgraph->m_code );
if( item->Type() == SCH_PIN_T )
{
auto pin = static_cast<SCH_PIN*>( item );
// Invisible power pins need to be post-processed later
if( pin->IsPowerConnection() && !pin->IsVisible() )
{
m_invisible_power_pins.push_back( pin );
}
}
std::list<SCH_ITEM*> members( item->ConnectedItems().begin(), std::list<SCH_ITEM*> members( item->ConnectedItems().begin(),
item->ConnectedItems().end() ); item->ConnectedItems().end() );
@ -1879,6 +1872,26 @@ bool CONNECTION_GRAPH::ercCheckNoConnects( CONNECTION_SUBGRAPH* aSubgraph,
} }
} }
// Check if invisible power pins connect to anything else
// Note this won't catch if a component has multiple invisible power
// pins but these don't connect to any other net; maybe that should be
// added as a further optional ERC check.
if( pin && !has_other_connections &&
pin->IsPowerConnection() && !pin->IsVisible() )
{
wxString name = pin->Connection( sheet )->Name();
if( int code = m_net_name_to_code_map.count( name ) )
{
if( m_net_code_to_subgraphs_map.count( code ) )
{
if( m_net_code_to_subgraphs_map.at( code ).size() > 1 )
has_other_connections = true;
}
}
}
if( pin && !has_other_connections && pin->GetType() != PIN_NC ) if( pin && !has_other_connections && pin->GetType() != PIN_NC )
{ {
SCH_COMPONENT* comp = pin->GetParentComponent(); SCH_COMPONENT* comp = pin->GetParentComponent();