haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove SMD pad side sanity check.

This commit is contained in:
Jeff Young 2022-09-04 22:36:17 +01:00
parent 0e95f06c7b
commit c0ba1b35bf
4 changed files with 0 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pcbnew/dialogs/dialog_footprint_checker.cpp
View File

@ -178,12 +178,6 @@ void DIALOG_FOOTPRINT_CHECKER::runChecks()
} );
}
footprint->CheckSMDSide(
[&]( const PAD* aPadA, const PAD* aPadB, const wxString& aMsg )
{
errorHandler( aPadA, aPadB, nullptr, DRCE_FOOTPRINT, aMsg, aPadA->GetPosition() );
} );
m_checksRun = true;
m_markersTreeModel->Update( m_markersProvider, m_severities );

8
pcbnew/drc/drc_test_provider_footprint_checks.cpp
View File

@ -138,14 +138,6 @@ bool DRC_TEST_PROVIDER_FOOTPRINT_CHECKS::Run()
footprint->GetPosition(), footprint->GetLayer() );
} );
}
footprint->CheckSMDSide(
[&]( const PAD* aPadA, const PAD* aPadB, const wxString& aMsg )
{
errorHandler( aPadA, aPadB, nullptr, DRCE_FOOTPRINT, aMsg,
aPadA->GetPosition(), aPadA->GetPrincipalLayer() );
} );
}
return !m_drcEngine->IsCancelled();

25
pcbnew/footprint.cpp
View File

@ -2571,31 +2571,6 @@ void FOOTPRINT::CheckNetTiePadGroups( const std::function<void( const wxString&
}
void FOOTPRINT::CheckSMDSide( const std::function<void( const PAD*, const PAD*,
const wxString& aMsg )>& aErrorHandler )
{
PAD* firstFront = nullptr;
PAD* firstBack = nullptr;
for( PAD* pad : Pads() )
{
if( pad->GetAttribute() == PAD_ATTRIB::SMD )
{
if( pad->IsOnLayer( F_Cu ) && !firstFront )
firstFront = pad;
else if( pad->IsOnLayer( B_Cu ) && !firstBack )
firstBack = pad;
}
}
if( firstFront && firstBack )
{
aErrorHandler( firstFront, firstBack,
_( "(footprint contains SMD pads on both front and back)" ) );
}
}
void FOOTPRINT::SwapData( BOARD_ITEM* aImage )
{
wxASSERT( aImage->Type() == PCB_FOOTPRINT_T );

9
pcbnew/footprint.h
View File

@ -413,15 +413,6 @@ public:
*/
void CheckNetTiePadGroups( const std::function<void( const wxString& )>& aErrorHandler );
/**
* Sanity check SMD pads. A footprint containing both front and back copper SMD pads is
* highly suspicious.
*
* @param aErrorHandler callback to handle the error messages generated
*/
void CheckSMDSide( const std::function<void( const PAD*,
const PAD*,
const wxString& aMsg )>& aErrorHandler );
/**
* Generate pads shapes on layer \a aLayer as polygons and adds these polygons to
* \a aCornerBuffer.