haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Set DoubleBuffering to reduce flicker" 

This reverts commit 106259f6e6.

In its place, we set double buffering to only menubars in an attempt to
find a soluton to #4785

Fixes https://gitlab.com/kicad/code/kicad/issues/4863
This commit is contained in:
Seth Hillbrand 2020-07-11 09:37:05 -07:00
parent c407e96b14
commit c18cab6154
15 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
3d-viewer/3d_viewer/3d_menubar.cpp
View File

@ -319,6 +319,7 @@ void EDA_3D_VIEWER::CreateMenuBar()
menuBar->Append( viewMenu, _( "&View" ) );
menuBar->Append( prefsMenu, _( "&Preferences" ) );
AddStandardHelpMenu( menuBar );
menuBar->SetDoubleBuffered( true );
SetMenuBar( menuBar );
}

1
cvpcb/menubar.cpp
View File

@ -103,6 +103,7 @@ void CVPCB_MAINFRAME::ReCreateMenuBar()
menuBar->Append( editMenu, _( "&Edit" ) );
menuBar->Append( prefsMenu, _( "&Preferences" ) );
AddStandardHelpMenu( menuBar );
menuBar->SetDoubleBuffered( true );
SetMenuBar( menuBar );
delete oldMenuBar;

1
eeschema/libedit/menubar_libedit.cpp
View File

@ -229,6 +229,7 @@ void LIB_EDIT_FRAME::ReCreateMenuBar()
menuBar->Append( inspectMenu, _( "&Inspect" ) );
menuBar->Append( prefsMenu, _( "P&references" ) );
AddStandardHelpMenu( menuBar );
menuBar->SetDoubleBuffered( true );
SetMenuBar( menuBar );
delete oldMenuBar;

1
eeschema/menubar.cpp
View File

@ -343,6 +343,7 @@ void SCH_EDIT_FRAME::ReCreateMenuBar()
menuBar->Append( toolsMenu, _( "&Tools" ) );
menuBar->Append( prefsMenu, _( "P&references" ) );
AddStandardHelpMenu( menuBar );
menuBar->SetDoubleBuffered( true );
SetMenuBar( menuBar );
delete oldMenuBar;

2
eeschema/sch_draw_panel.cpp
View File

@ -197,8 +197,6 @@ void SCH_DRAW_PANEL::OnShow()
if( frame )
frame->ActivateGalCanvas();
}
m_parent->SetDoubleBuffered( true );
}

2
eeschema/sch_preview_panel.cpp
View File

@ -87,8 +87,6 @@ SCH_PREVIEW_PANEL::~SCH_PREVIEW_PANEL()
void SCH_PREVIEW_PANEL::OnShow()
{
m_parent->SetDoubleBuffered( true );
//m_view->RecacheAllItems();
}

1
eeschema/toolbars_lib_view.cpp
View File

@ -138,6 +138,7 @@ void LIB_VIEW_FRAME::ReCreateMenuBar()
menuBar->Append( fileMenu, _( "&File" ) );
menuBar->Append( viewMenu, _( "&View" ) );
AddStandardHelpMenu( menuBar );
menuBar->SetDoubleBuffered( true );
SetMenuBar( menuBar );
delete oldMenuBar;

1
gerbview/gerbview_draw_panel_gal.cpp
View File

@ -100,7 +100,6 @@ void GERBVIEW_DRAW_PANEL_GAL::OnShow()
if( frame )
{
m_parent->SetDoubleBuffered( true );
SetTopLayer( frame->GetActiveLayer() );
auto& displ_opts = frame->GetDisplayOptions();
static_cast<KIGFX::GERBVIEW_RENDER_SETTINGS*>(

1
gerbview/menubar.cpp
View File

@ -266,6 +266,7 @@ void GERBVIEW_FRAME::ReCreateMenuBar()
menuBar->Append( toolsMenu, _( "&Tools" ) );
menuBar->Append( preferencesMenu, _( "&Preferences" ) );
AddStandardHelpMenu( menuBar );
menuBar->SetDoubleBuffered( true );
// Associate the menu bar with the frame, if no previous menubar
SetMenuBar( menuBar );

1
kicad/menubar.cpp
View File

@ -162,6 +162,7 @@ void KICAD_MANAGER_FRAME::ReCreateMenuBar()
menuBar->Append( toolsMenu, _( "&Tools" ) );
menuBar->Append( prefsMenu, _( "&Preferences" ) );
AddStandardHelpMenu( menuBar );
menuBar->SetDoubleBuffered( true );
SetMenuBar( menuBar );
delete oldMenuBar;

1
pagelayout_editor/menubar.cpp
View File

@ -189,6 +189,7 @@ void PL_EDITOR_FRAME::ReCreateMenuBar()
menuBar->Append( inspectorMenu, _( "&Inspect" ) );
menuBar->Append( preferencesMenu, _( "P&references" ) );
AddStandardHelpMenu( menuBar );
menuBar->SetDoubleBuffered( true );
SetMenuBar( menuBar );
delete oldMenuBar;

1
pcbnew/menubar_footprint_editor.cpp
View File

@ -305,6 +305,7 @@ void FOOTPRINT_EDIT_FRAME::ReCreateMenuBar()
menuBar->Append( toolsMenu, _( "&Tools" ) );
menuBar->Append( prefsMenu, _( "P&references" ) );
AddStandardHelpMenu( menuBar );
menuBar->SetDoubleBuffered( true );
SetMenuBar( menuBar );
delete oldMenuBar;

1
pcbnew/menubar_pcb_editor.cpp
View File

@ -555,6 +555,7 @@ void PCB_EDIT_FRAME::ReCreateMenuBar()
menuBar->Append( toolsMenu, _( "&Tools" ) );
menuBar->Append( prefsMenu, _( "P&references" ) );
AddStandardHelpMenu( menuBar );
menuBar->SetDoubleBuffered( true );
SetMenuBar( menuBar );
delete oldMenuBar;

1
pcbnew/pcb_draw_panel_gal.cpp
View File

@ -416,7 +416,6 @@ void PCB_DRAW_PANEL_GAL::OnShow()
if( frame )
{
m_parent->SetDoubleBuffered( true );
SetTopLayer( frame->GetActiveLayer() );
KIGFX::PAINTER* painter = m_view->GetPainter();
auto settings = static_cast<KIGFX::PCB_RENDER_SETTINGS*>( painter->GetSettings() );

1
pcbnew/toolbars_footprint_viewer.cpp
View File

@ -189,6 +189,7 @@ void FOOTPRINT_VIEWER_FRAME::ReCreateMenuBar()
menuBar->Append( fileMenu, _( "&File" ) );
menuBar->Append( viewMenu, _( "&View" ) );
AddStandardHelpMenu( menuBar );
menuBar->SetDoubleBuffered( true );
SetMenuBar( menuBar );
delete oldMenuBar;