haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Speed optimization during selection of multiple items. 

Removed debug output.
This commit is contained in:
Maciej Suminski 2013-12-18 15:09:09 +01:00
parent 873235304e
commit c1d6e44413
2 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pcbnew/tools/edit_tool.cpp
View File

@ -129,12 +129,6 @@ int EDIT_TOOL::Main( TOOL_EVENT& aEvent )
else else
{ {
// Prepare to drag - save items, so changes can be undone // Prepare to drag - save items, so changes can be undone
for( unsigned int i = 0; i < selection.items.GetCount(); ++i )
{
BOARD_ITEM* item = static_cast<BOARD_ITEM*>( selection.items.GetPickedItem( i ) );
std::cout << "saved " << (unsigned long) item << std::endl;
}
editFrame->OnModify(); editFrame->OnModify();
editFrame->SaveCopyInUndoList( selection.items, UR_CHANGED ); editFrame->SaveCopyInUndoList( selection.items, UR_CHANGED );

6
pcbnew/tools/selection_tool.cpp
View File

@ -503,7 +503,6 @@ void SELECTION_TOOL::select( BOARD_ITEM* aItem )
{ {
MODULE* module = static_cast<MODULE*>( aItem ); MODULE* module = static_cast<MODULE*>( aItem );
module->RunOnChildren( std::bind1st( std::mem_fun( &SELECTION_TOOL::selectVisually ), this ) ); module->RunOnChildren( std::bind1st( std::mem_fun( &SELECTION_TOOL::selectVisually ), this ) );
} }
selectVisually( aItem ); selectVisually( aItem );
@ -519,8 +518,8 @@ void SELECTION_TOOL::select( BOARD_ITEM* aItem )
// Now the context menu should be enabled // Now the context menu should be enabled
SetContextMenu( &m_menu, CMENU_BUTTON ); SetContextMenu( &m_menu, CMENU_BUTTON );
} }
else else if( m_selection.Size() == 2 ) // Check only for 2, so it will not be
{ { // called for every next selected item
// If multiple items are selected, do not show the information about the selected item // If multiple items are selected, do not show the information about the selected item
getEditFrame<PCB_EDIT_FRAME>()->SetCurItem( NULL, true ); getEditFrame<PCB_EDIT_FRAME>()->SetCurItem( NULL, true );
} }
@ -535,7 +534,6 @@ void SELECTION_TOOL::deselect( BOARD_ITEM* aItem )
{ {
MODULE* module = static_cast<MODULE*>( aItem ); MODULE* module = static_cast<MODULE*>( aItem );
module->RunOnChildren( std::bind1st( std::mem_fun( &SELECTION_TOOL::deselectVisually ), this ) ); module->RunOnChildren( std::bind1st( std::mem_fun( &SELECTION_TOOL::deselectVisually ), this ) );
} }
deselectVisually( aItem ); deselectVisually( aItem );