haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pl-editor: Don't update the properties panel while adding an text item 

Fixes https://gitlab.com/kicad/code/kicad/-/issues/7074
This commit is contained in:
Roberto Fernandez Bautista 2021-01-13 19:56:09 +00:00 committed by Jon Evans
parent 36508807e7
commit c3190627e2
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pagelayout_editor/tools/pl_drawing_tools.cpp
View File

@ -161,7 +161,10 @@ int PL_DRAWING_TOOLS::PlaceItem( const TOOL_EVENT& aEvent )
item = dataItem->GetDrawItems()[0]; item = dataItem->GetDrawItems()[0];
item->SetFlags( IS_NEW | IS_MOVED ); item->SetFlags( IS_NEW | IS_MOVED );
m_selectionTool->AddItemToSel( item );
// Select the item but don't inform other tools (to prevent the Properties
// panel from updating the item before it has been placed)
m_selectionTool->AddItemToSel( item, true );
// update the cursor so it looks correct before another event // update the cursor so it looks correct before another event
setCursor(); setCursor();
@ -175,6 +178,11 @@ int PL_DRAWING_TOOLS::PlaceItem( const TOOL_EVENT& aEvent )
item->ClearEditFlags(); item->ClearEditFlags();
getView()->Update( item ); getView()->Update( item );
// Now we re-select and inform other tools, so that the Properties panel
// is updated.
m_toolMgr->RunAction( PL_ACTIONS::clearSelection, true );
m_selectionTool->AddItemToSel( item, false );
item = nullptr; item = nullptr;
m_frame->OnModify(); m_frame->OnModify();