haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't dirty the item connectivity prematurely 

Item connectivity changes once the elements are commited, not during the
process of moving.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14884
This commit is contained in:
Seth Hillbrand 2023-06-05 09:11:16 -07:00
parent d48858e298
commit c33d1ab244
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
eeschema/tools/sch_move_tool.cpp
View File

@ -604,7 +604,7 @@ int SCH_MOVE_TOOL::Main( const TOOL_EVENT& aEvent )
} }
else else
{ {
saveCopyInUndoList( (SCH_ITEM*) item, UNDO_REDO::CHANGED, appendUndo ); saveCopyInUndoList( (SCH_ITEM*) item, UNDO_REDO::CHANGED, appendUndo, false );
appendUndo = true; appendUndo = true;
} }
@ -923,8 +923,13 @@ int SCH_MOVE_TOOL::Main( const TOOL_EVENT& aEvent )
{ {
// One last update after exiting loop (for slower stuff, such as updating SCREEN's RTree). // One last update after exiting loop (for slower stuff, such as updating SCREEN's RTree).
for( EDA_ITEM* item : selection ) for( EDA_ITEM* item : selection )
{
updateItem( item, true ); updateItem( item, true );
if( SCH_ITEM* sch_item = dynamic_cast<SCH_ITEM*>( item ) )
sch_item->SetConnectivityDirty( true );
}
m_selectionTool->RemoveItemsFromSel( &m_dragAdditions, QUIET_MODE ); m_selectionTool->RemoveItemsFromSel( &m_dragAdditions, QUIET_MODE );
// If we move items away from a junction, we _may_ want to add a junction there // If we move items away from a junction, we _may_ want to add a junction there