haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Only run starved-thermals checks when pad is actually connected to zone. 

Fixes https://gitlab.com/kicad/code/kicad/issues/10583
This commit is contained in:
Jeff Young 2022-02-02 12:41:30 +00:00
parent 53cf899b67
commit c8d14ade65
2 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pcbnew/drc/drc_test_provider_zone_connections.cpp
View File

@ -106,15 +106,14 @@ bool DRC_TEST_PROVIDER_ZONE_CONNECTIONS::Run()
if( m_drcEngine->IsErrorLimitExceeded( DRCE_STARVED_THERMAL ) ) if( m_drcEngine->IsErrorLimitExceeded( DRCE_STARVED_THERMAL ) )
return true; return true;
if( !pad->FlashLayer( layer ) ) // Quick test for connected:
continue;
if( pad->GetNetCode() != zone->GetNetCode() || pad->GetNetCode() <= 0 ) if( pad->GetNetCode() != zone->GetNetCode() || pad->GetNetCode() <= 0 )
continue; continue;
EDA_RECT item_boundingbox = pad->GetBoundingBox(); // More thorough test for connected:
const KICAD_T type_zone[] = { PCB_ZONE_T, EOT };
if( !item_boundingbox.Intersects( zone->GetCachedBoundingBox() ) ) if( !alg::contains( connectivity->GetConnectedItems( pad, type_zone ), zone ) )
continue; continue;
constraint = bds.m_DRCEngine->EvalZoneConnection( pad, zone, layer ); constraint = bds.m_DRCEngine->EvalZoneConnection( pad, zone, layer );

15
pcbnew/tools/board_inspection_tool.cpp
View File

@ -409,12 +409,25 @@ int BOARD_INSPECTION_TOOL::InspectClearance( const TOOL_EVENT& aEvent )
constraint = drcEngine.EvalRules( THERMAL_SPOKE_WIDTH_CONSTRAINT, pad, zone, layer, r ); constraint = drcEngine.EvalRules( THERMAL_SPOKE_WIDTH_CONSTRAINT, pad, zone, layer, r );
int width = constraint.m_Value.Opt(); int width = constraint.m_Value.Opt();
r->Report( "" );
r->Report( wxString::Format( _( "Resolved thermal spoke width: %s." ),
StringFromValue( units, width, true ) ) );
constraint = drcEngine.EvalRules( MIN_RESOLVED_SPOKES_CONSTRAINT, pad, zone, layer, r );
int minSpokes = constraint.m_Value.Min();
if( compileError ) if( compileError )
reportCompileError( r ); reportCompileError( r );
r->Report( "" ); r->Report( "" );
r->Report( wxString::Format( _( "Resolved thermal spoke width: %s." ), r->Report( wxString::Format( _( "Minimum thermal spoke count: %s." ),
StringFromValue( units, width, true ) ) ); StringFromValue( units, width, true ) ) );
std::shared_ptr<CONNECTIVITY_DATA> connectivity = pad->GetBoard()->GetConnectivity();
const KICAD_T zones[] = { PCB_ZONE_T, EOT };
if( !alg::contains( connectivity->GetConnectedItems( pad, zones ), zone ) )
r->Report( _( "Items are not connected. No thermal spokes will be generated." ) );
} }
else if( constraint.m_ZoneConnection == ZONE_CONNECTION::NONE ) else if( constraint.m_ZoneConnection == ZONE_CONNECTION::NONE )
{ {