haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Try and reduce memory allocs when (un)escaping strings

This commit is contained in:
Marek Roszko 2022-03-08 19:36:08 -05:00
parent e4b56ab7f1
commit ca5049b6bc
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
common/string_utils.cpp
View File

@ -142,6 +142,8 @@ wxString EscapeString( const wxString& aSource, ESCAPE_CONTEXT aContext )
{ {
wxString converted; wxString converted;
converted.reserve( aSource.length() );
for( wxUniChar c: aSource ) for( wxUniChar c: aSource )
{ {
if( aContext == CTX_NETNAME ) if( aContext == CTX_NETNAME )
@ -243,9 +245,17 @@ wxString EscapeString( const wxString& aSource, ESCAPE_CONTEXT aContext )
wxString UnescapeString( const wxString& aSource ) wxString UnescapeString( const wxString& aSource )
{ {
wxString newbuf;
size_t sourceLen = aSource.length(); size_t sourceLen = aSource.length();
// smallest escape string is three characters, shortcut everything else
if( sourceLen <= 2 )
{
return aSource;
}
wxString newbuf;
newbuf.reserve( sourceLen );
for( size_t i = 0; i < sourceLen; ++i ) for( size_t i = 0; i < sourceLen; ++i )
{ {
wxUniChar ch = aSource[i]; wxUniChar ch = aSource[i];