haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix some build warnings

This commit is contained in:
Ian McInerney 2020-04-06 00:31:45 +01:00
parent 7bce0e17f2
commit cb380cda0c
3 changed files with 10 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
3d-viewer/3d_viewer/dialogs/dialog_3D_view_option.cpp
View File

@ -30,10 +30,9 @@
class DIALOG_3D_VIEW_OPTIONS : public DIALOG_3D_VIEW_OPTIONS_BASE
{
public:
explicit DIALOG_3D_VIEW_OPTIONS( EDA_3D_VIEWER* parent );
explicit DIALOG_3D_VIEW_OPTIONS( EDA_3D_VIEWER* aParent );
private:
EDA_3D_VIEWER* m_parent;
BOARD_ADAPTER& m_settings;
void initDialog();
@ -57,10 +56,9 @@ void EDA_3D_VIEWER::Install3DViewOptionDialog( wxCommandEvent& event )
}
DIALOG_3D_VIEW_OPTIONS::DIALOG_3D_VIEW_OPTIONS( EDA_3D_VIEWER* parent ) :
DIALOG_3D_VIEW_OPTIONS_BASE( parent ),
m_parent( parent ),
m_settings( parent->GetAdapter() )
DIALOG_3D_VIEW_OPTIONS::DIALOG_3D_VIEW_OPTIONS( EDA_3D_VIEWER* aParent ) :
DIALOG_3D_VIEW_OPTIONS_BASE( aParent ),
m_settings( aParent->GetAdapter() )
{
initDialog();

7
common/advanced_config.cpp
View File

@ -67,13 +67,6 @@ namespace AC_KEYS
*/
static const wxChar UsePadProperty[] = wxT( "UsePadProperty" );
/**
* In Pcbnew, pads can handle a pin function info (this is the schematic pin name)
* Because this feature adds a new keyword in *.kicad_pcb files, this is an advanced feature
* until it is fully finalized
*/
static const wxChar UsePinFunction[] = wxT( "UsePinFunction" );
/**
* Testing mode for new connectivity algorithm. Setting this to on will cause all modifications
* to the netlist to be recalculated on the fly. This may be slower than the standard process

12
pcbnew/dialogs/dialog_export_svg.cpp
View File

@ -228,9 +228,9 @@ void DIALOG_EXPORT_SVG::ExportSVGFile( bool aOnlyOneFile )
// Create output directory if it does not exist (also transform it in
// absolute form). Bail if it fails
wxString path = ExpandEnvVarSubstitutions( m_outputDirectory, &Prj() );
wxString path = ExpandEnvVarSubstitutions( m_outputDirectory, &Prj() );
wxFileName outputDir = wxFileName::DirName( path );
wxString boardFilename = m_board->GetFileName();
wxString boardFilename = m_board->GetFileName();
REPORTER& reporter = m_messagesPanel->Reporter();
@ -255,20 +255,20 @@ void DIALOG_EXPORT_SVG::ExportSVGFile( bool aOnlyOneFile )
wxString suffix = aOnlyOneFile ? wxT( "brd" ) : m_board->GetStandardLayerName( layer );
BuildPlotFileName( &fn, outputDir.GetPath(), suffix, SVGFileExtension );
wxString path = fn.GetFullPath();
wxString svgPath = fn.GetFullPath();
m_printMaskLayer = aOnlyOneFile ? all_selected : LSET( layer );
if( m_PrintBoardEdgesCtrl->IsChecked() )
m_printMaskLayer.set( Edge_Cuts );
if( CreateSVGFile( path ) )
if( CreateSVGFile( svgPath ) )
{
reporter.Report( wxString::Format( _( "Exported \"%s\"." ), path ), RPT_SEVERITY_ACTION );
reporter.Report( wxString::Format( _( "Exported \"%s\"." ), svgPath ), RPT_SEVERITY_ACTION );
}
else // Error
{
reporter.Report( wxString::Format( _( "Unable to create file \"%s\"." ), path ),
reporter.Report( wxString::Format( _( "Unable to create file \"%s\"." ), svgPath ),
RPT_SEVERITY_ERROR );
}