haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pcbnew: Fix crash when removing polygon corners 

GetSelectedRows() returns -1 when no rows are selected.

Fixes: lp:1798095
* https://bugs.launchpad.net/kicad/+bug/1798095
This commit is contained in:
Seth Hillbrand 2018-10-16 07:44:28 -07:00
parent 99549f816f
commit cccf4cf20b
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pcbnew/dialogs/dialog_pad_basicshapes_properties.cpp
View File

@ -240,9 +240,9 @@ bool DIALOG_PAD_PRIMITIVE_POLY_PROPS::TransferDataToWindow()
} }
// enter others corner coordinates // enter others corner coordinates
wxString msg;
for( unsigned row = 0; row < m_currshape.m_Poly.size(); ++row ) for( unsigned row = 0; row < m_currshape.m_Poly.size(); ++row )
{ {
wxString msg;
// Row label is "Corner x" // Row label is "Corner x"
msg.Printf( "Corner %d", row+1 ); msg.Printf( "Corner %d", row+1 );
m_gridCornersList->SetRowLabelValue( row, msg ); m_gridCornersList->SetRowLabelValue( row, msg );
@ -370,7 +370,8 @@ void DIALOG_PAD_PRIMITIVE_POLY_PROPS::OnButtonDelete( wxCommandEvent& event )
// remove corners: // remove corners:
for( int ii = selections.size()-1; ii >= 0 ; --ii ) for( int ii = selections.size()-1; ii >= 0 ; --ii )
{ {
m_currshape.m_Poly.erase( m_currshape.m_Poly.begin() + selections[ii] ); if( selections[ii] >= 0 )
m_currshape.m_Poly.erase( m_currshape.m_Poly.begin() + selections[ii] );
} }
// Unselect all raws: // Unselect all raws: