haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re-disable validator for VALUE and add comment explaining it

This commit is contained in:
Jon Evans 2023-02-25 08:05:02 -05:00
parent 8a9ac4f01f
commit d08157f7db
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
eeschema/dialogs/dialog_field_properties.cpp
View File

@ -157,8 +157,9 @@ void DIALOG_FIELD_PROPERTIES::init()
// Predefined fields cannot contain some chars, or cannot be empty, // Predefined fields cannot contain some chars, or cannot be empty,
// and need a SCH_FIELD_VALIDATOR (m_StyledTextCtrl cannot use a SCH_FIELD_VALIDATOR). // and need a SCH_FIELD_VALIDATOR (m_StyledTextCtrl cannot use a SCH_FIELD_VALIDATOR).
// VALUE_FIELD does not use the validator so that it uses the Scintilla text control, since we
// allow text replacement for this field (but not the other predefined fields)
bool use_validator = m_fieldId == REFERENCE_FIELD bool use_validator = m_fieldId == REFERENCE_FIELD
|| m_fieldId == VALUE_FIELD
|| m_fieldId == FOOTPRINT_FIELD || m_fieldId == FOOTPRINT_FIELD
|| m_fieldId == DATASHEET_FIELD || m_fieldId == DATASHEET_FIELD
|| m_fieldId == SHEETNAME_V || m_fieldId == SHEETNAME_V
@ -190,10 +191,12 @@ void DIALOG_FIELD_PROPERTIES::init()
"cannot be changed." ) ) ); "cannot be changed." ) ) );
m_note->Show( true ); m_note->Show( true );
m_TextCtrl->Enable( false ); m_TextCtrl->Enable( false );
m_StyledTextCtrl->Enable( false );
} }
else else
{ {
m_TextCtrl->Enable( true ); m_TextCtrl->Enable( true );
m_StyledTextCtrl->Enable( true );
} }
GetSizer()->SetSizeHints( this ); GetSizer()->SetSizeHints( this );