Cleanup (no functional changes).

This commit is contained in:
Jeff Young 2023-10-10 13:42:42 +01:00
parent 04e23bf5e3
commit d3b50f0607
1 changed files with 8 additions and 13 deletions

View File

@ -542,22 +542,10 @@ bool EDIT_TOOL::doMoveSelection( const TOOL_EVENT& aEvent, BOARD_COMMIT* aCommit
// Drag items to the current cursor position // Drag items to the current cursor position
for( EDA_ITEM* item : sel_items ) for( EDA_ITEM* item : sel_items )
{ {
// Don't double move footprint pads, fields, etc. // Don't double move child items.
//
// For PCB_GROUP_T, we make sure the selection includes only the top level
// group and not its descendants.
if( !item->GetParent() || !item->GetParent()->IsSelected() ) if( !item->GetParent() || !item->GetParent()->IsSelected() )
static_cast<BOARD_ITEM*>( item )->Move( movement ); static_cast<BOARD_ITEM*>( item )->Move( movement );
if( !redraw3D && item->Type() == PCB_FOOTPRINT_T )
redraw3D = true;
}
if( redraw3D && allowRedraw3D )
editFrame->Update3DView( false, true );
for( BOARD_ITEM* item : sel_items )
{
if( item->Type() == PCB_GENERATOR_T ) if( item->Type() == PCB_GENERATOR_T )
{ {
PCB_GENERATOR* generator = static_cast<PCB_GENERATOR*>( item ); PCB_GENERATOR* generator = static_cast<PCB_GENERATOR*>( item );
@ -565,8 +553,15 @@ bool EDIT_TOOL::doMoveSelection( const TOOL_EVENT& aEvent, BOARD_COMMIT* aCommit
m_toolMgr->RunSynchronousAction<PCB_GENERATOR*>( PCB_ACTIONS::genUpdateEdit, m_toolMgr->RunSynchronousAction<PCB_GENERATOR*>( PCB_ACTIONS::genUpdateEdit,
aCommit, generator ); aCommit, generator );
} }
else if( item->Type() == PCB_FOOTPRINT_T )
{
redraw3D = true;
}
} }
if( redraw3D && allowRedraw3D )
editFrame->Update3DView( false, true );
if( showCourtyardConflicts && drc_on_move->m_FpInMove.size() ) if( showCourtyardConflicts && drc_on_move->m_FpInMove.size() )
{ {
drc_on_move->Run(); drc_on_move->Run();