haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re-enable corner radius of DP meanders. 

It appears whatever bugs it had have been addressed.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15257
This commit is contained in:
Jeff Young 2023-11-22 19:45:25 +00:00
parent e9c5b4755b
commit d437d872ab
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pcbnew/dialogs/dialog_tuning_pattern_properties.cpp
View File

@ -49,7 +49,6 @@ DIALOG_TUNING_PATTERN_PROPERTIES::DIALOG_TUNING_PATTERN_PROPERTIES( PCB_BASE_EDI
case PNS::PNS_MODE_TUNE_DIFF_PAIR: case PNS::PNS_MODE_TUNE_DIFF_PAIR:
m_legend->SetBitmap( KiBitmapBundle( BITMAPS::tune_diff_pair_length_legend ) ); m_legend->SetBitmap( KiBitmapBundle( BITMAPS::tune_diff_pair_length_legend ) );
m_r.Enable( false );
break; break;
case PNS::PNS_MODE_TUNE_DIFF_PAIR_SKEW: case PNS::PNS_MODE_TUNE_DIFF_PAIR_SKEW:

6
pcbnew/router/pns_meander.cpp
View File

@ -216,10 +216,8 @@ int MEANDER_SHAPE::MinAmplitude() const
int MEANDER_SHAPE::cornerRadius() const int MEANDER_SHAPE::cornerRadius() const
{ {
// TODO: fix diff-pair meandering so we can use non-100% radii int rPercent = Settings().m_cornerRadiusPercentage;
int rPercent = m_dual ? 100 : Settings().m_cornerRadiusPercentage; int optCr = static_cast<int>( static_cast<SEG::ecoord>( spacing() ) * rPercent / 200 );
int optCr = (int64_t) spacing() * rPercent / 200;
int minCr = std::abs( m_baselineOffset ); int minCr = std::abs( m_baselineOffset );
int maxCr = std::min( m_amplitude / 2, spacing() / 2 ); int maxCr = std::min( m_amplitude / 2, spacing() / 2 );