haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a few compil and Coverity warnings.

This commit is contained in:
jean-pierre charras 2020-10-25 10:02:07 +01:00
parent dbcb1ecdb7
commit d6f91c810f
8 changed files with 27 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
common/page_layout/ws_proxy_view_item.cpp
View File

@ -41,6 +41,7 @@ WS_PROXY_VIEW_ITEM::WS_PROXY_VIEW_ITEM( int aMils2IUscalefactor, const PAGE_INFO
m_pageInfo( aPageInfo ), m_pageInfo( aPageInfo ),
m_pageNumber( "1" ), m_pageNumber( "1" ),
m_sheetCount( 1 ), m_sheetCount( 1 ),
m_isFirstPage( false ),
m_project( aProject ), m_project( aProject ),
m_colorLayer( LAYER_WORKSHEET ), m_colorLayer( LAYER_WORKSHEET ),
m_pageBorderColorLayer( LAYER_GRID ) m_pageBorderColorLayer( LAYER_GRID )

2
eeschema/dialogs/dialog_choose_component.h
View File

@ -168,7 +168,7 @@ protected:
wxPanel* ConstructRightPanel( wxWindow* aParent ); wxPanel* ConstructRightPanel( wxWindow* aParent );
void OnInitDialog( wxInitDialogEvent& aEvent ); void OnInitDialog( wxInitDialogEvent& aEvent );
void OnCharHook( wxKeyEvent& aEvt ); void OnCharHook( wxKeyEvent& aEvt ) override;
void OnCloseTimer( wxTimerEvent& aEvent ); void OnCloseTimer( wxTimerEvent& aEvent );
void OnUseBrowser( wxCommandEvent& aEvent ); void OnUseBrowser( wxCommandEvent& aEvent );

2
libs/kimath/src/geometry/shape_arc.cpp
View File

@ -57,6 +57,8 @@ SHAPE_ARC::SHAPE_ARC( const VECTOR2I& aArcStart, const VECTOR2I& aArcMid,
SHAPE_ARC::SHAPE_ARC( const SEG& aSegmentA, const SEG& aSegmentB, int aRadius, int aWidth ) SHAPE_ARC::SHAPE_ARC( const SEG& aSegmentA, const SEG& aSegmentB, int aRadius, int aWidth )
: SHAPE( SH_ARC ) : SHAPE( SH_ARC )
{ {
m_width = aWidth;
/* /*
* Construct an arc that is tangent to two segments with a given radius. * Construct an arc that is tangent to two segments with a given radius.
* *

2
pcbnew/dialogs/dialog_text_properties.h
View File

@ -63,7 +63,7 @@ private:
bool TransferDataToWindow() override; bool TransferDataToWindow() override;
bool TransferDataFromWindow() override; bool TransferDataFromWindow() override;
void OnCharHook( wxKeyEvent& aEvent ); void OnCharHook( wxKeyEvent& aEvent ) override;
}; };

3
pcbnew/drc/drc_test_provider_diff_pair_coupling.cpp
View File

@ -55,7 +55,8 @@ namespace test {
class DRC_TEST_PROVIDER_DIFF_PAIR_COUPLING : public DRC_TEST_PROVIDER class DRC_TEST_PROVIDER_DIFF_PAIR_COUPLING : public DRC_TEST_PROVIDER
{ {
public: public:
DRC_TEST_PROVIDER_DIFF_PAIR_COUPLING () DRC_TEST_PROVIDER_DIFF_PAIR_COUPLING () :
m_board( nullptr )
{ {
} }

3
pcbnew/drc/drc_test_provider_matched_length.cpp
View File

@ -47,7 +47,8 @@ namespace test {
class DRC_TEST_PROVIDER_MATCHED_LENGTH : public DRC_TEST_PROVIDER class DRC_TEST_PROVIDER_MATCHED_LENGTH : public DRC_TEST_PROVIDER
{ {
public: public:
DRC_TEST_PROVIDER_MATCHED_LENGTH () DRC_TEST_PROVIDER_MATCHED_LENGTH () :
m_board( nullptr )
{ {
} }

2
pcbnew/router/router_tool.cpp
View File

@ -344,7 +344,7 @@ protected:
} }
else else
{ {
msg.Printf( _( "Width %s, via gap %s " ), msg.Printf( _( "Width %s, via gap %s" ),
MessageTextFromValue( units, diffPair.m_Width ), MessageTextFromValue( units, diffPair.m_Width ),
MessageTextFromValue( units, diffPair.m_ViaGap ) ); MessageTextFromValue( units, diffPair.m_ViaGap ) );
} }

3
pcbnew/zone_filler.cpp
View File

@ -56,7 +56,8 @@ ZONE_FILLER::ZONE_FILLER( BOARD* aBoard, COMMIT* aCommit ) :
m_brdOutlinesValid( false ), m_brdOutlinesValid( false ),
m_commit( aCommit ), m_commit( aCommit ),
m_progressReporter( nullptr ), m_progressReporter( nullptr ),
m_maxError( ARC_HIGH_DEF ) m_maxError( ARC_HIGH_DEF ),
m_worstClearance( 0 )
{ {
// To enable add "DebugZoneFiller=1" to kicad_advanced settings file. // To enable add "DebugZoneFiller=1" to kicad_advanced settings file.
m_debugZoneFiller = ADVANCED_CFG::GetCfg().m_DebugZoneFiller; m_debugZoneFiller = ADVANCED_CFG::GetCfg().m_DebugZoneFiller;